Repository navigation
feat: support StackState with self-signed certificates - #162
Merged
Merged
Conversation
Trust a mounted CA through SSL_CERT_DIR (chart: extraVolumes/extraVolumeMounts), or skip verification with stackstate.insecureSkipVerify. Both go through extension-kit's exttls, shared with the other extensions.
|
Claude finished @achoimet's task in 11s —— View job Review of PR #162
No blocking issues found.
|
achoimet
marked this pull request as ready for review
October 20, 2026 15:06
The rejection check relied on running first: handshake errors from an earlier scenario would otherwise satisfy it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of Extensions support self-signed certificates. Same pattern as steadybit/extension-grafana#114.
Uses
exttlsfrom extension-kit v1.12.2 (steadybit/extension-kit#193).Adds the two options every extension talking to a self-hostable service should offer:
extraVolumes/extraVolumeMounts, so the CA can be mounted and added toSSL_CERT_DIRviaextraEnv.stackstate.insecureSkipVerifyvalue →STEADYBIT_EXTENSION_INSECURE_SKIP_VERIFY.The StackState resty client uses
exttls.Transport(); it is the only outbound client. README section "Importing your own certificates", chart version bumped to 1.1.41.Tests
Helm unittest: new snapshot with custom certificates + insecureSkipVerify (24/24 pass).
Unit tests pass.
New e2e
TestWithMinikubeSelfSignedCertificate: the mock StackState is served over HTTPS with a self-signed certificate forhost.minikube.internal, one cluster per scenario:stackstate.insecureSkipVerify=true→ services discoveredSSL_CERT_DIR→ services discoveredAll three pass locally (276s).