Expand secret outside of run block in github ci build

Author: steinarb

.github/workflows/frontend-karaf-demo-maven-ci-build.yml

@@ -23,13 +23,16 @@ jobs:
           cp .github/workflows/settings.xml /home/runner/.m2
           mkdir -p /home/runner/.ssh
           ssh-keyscan maven.bang.priv.no >> /home/runner/.ssh/known_hosts
-          echo "${{ secrets.MAVEN_SSH_KEY }}" > /home/runner/.ssh/github_actions
+          echo "$MAVEN_SSH_KEY" > /home/runner/.ssh/github_actions
           chmod 600 /home/runner/.ssh/github_actions
+      env:
+        MAVEN_SSH_KEY: ${{ secrets.MAVEN_SSH_KEY }}
     - name: Build with Maven
-      run: mvn -B org.jacoco:jacoco-maven-plugin:prepare-agent install coveralls:report sonar:sonar --file pom.xml --define repoToken=${{ secrets.COVERALLS_REPO_SECRET }} -Dsonar.projectKey=steinarb_frontend-karaf-demo -Dsonar.organization=steinarb -Dsonar.host.url=https://sonarcloud.io
+      run: mvn -B org.jacoco:jacoco-maven-plugin:prepare-agent install coveralls:report sonar:sonar --file pom.xml --define repoToken="$COVERALLS_REPO_TOKEN" -Dsonar.projectKey=steinarb_frontend-karaf-demo -Dsonar.organization=steinarb -Dsonar.host.url=https://sonarcloud.io
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_SECRET }}
     - name: Deploy snapshot to maven repo
       run: mvn -B deploy -DskipTests=true
       env:

.github/workflows/frontend-karaf-demo-maven-pr-ci-build.yml

@@ -23,10 +23,13 @@ jobs:
           cp .github/workflows/settings.xml /home/runner/.m2
           mkdir -p /home/runner/.ssh
           ssh-keyscan maven.bang.priv.no >> /home/runner/.ssh/known_hosts
-          echo "${{ secrets.MAVEN_SSH_KEY }}" > /home/runner/.ssh/github_actions
+          echo "$MAVEN_SSH_KEY" > /home/runner/.ssh/github_actions
           chmod 600 /home/runner/.ssh/github_actions
+      env:
+        MAVEN_SSH_KEY: ${{ secrets.MAVEN_SSH_KEY }}
     - name: Build with Maven
-      run: mvn -B org.jacoco:jacoco-maven-plugin:prepare-agent install coveralls:report sonar:sonar --file pom.xml --define repoToken=${{ secrets.COVERALLS_REPO_SECRET }} -Dsonar.projectKey=steinarb_frontend-karaf-demo -Dsonar.organization=steinarb -Dsonar.host.url=https://sonarcloud.io
+      run: mvn -B org.jacoco:jacoco-maven-plugin:prepare-agent install coveralls:report sonar:sonar --file pom.xml --define repoToken="$COVERALLS_REPO_TOKEN" -Dsonar.projectKey=steinarb_frontend-karaf-demo -Dsonar.organization=steinarb -Dsonar.host.url=https://sonarcloud.io
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_SECRET }}