Skip to content

Example-contract snapshots still show pre-SEP-41 expiration_ledger name #2653

Description

@leighmcculloch

soroban-sdk v27.0.1 renamed the token approve function's allowance-expiration argument from expiration_ledger to live_until_ledger, to match SEP-41 (stellar/rs-soroban-sdk#1932). PR #2652 updates the hand-written token interface reference docs to match.

Three other pages still show the old expiration_ledger name. Each embeds a copy of an example contract's source pinned to a specific tag, so the name won't update until the upstream example changes and the snapshot is re-synced:

  • docs/build/smart-contracts/example-contracts/tokens.mdx — the soroban-examples token contract, pinned to v23.0.0.
  • docs/build/smart-contracts/example-contracts/fungible-token.mdx — OpenZeppelin's stellar-contracts fungible-token example.
  • docs/learn/migrate/evm/smart-contract-deployment.mdx — a hand-written TokenTrait from an older SDK snapshot (pre-MuxedAddress, ~v22.0.1).

These were left out of #2652 because editing them would make each snippet diverge from the tagged source it reproduces. Someone should check when soroban-examples and OpenZeppelin's stellar-contracts pick up the rename upstream, then refresh the first two pages. The EVM migration snapshot isn't tied to a tag, so it can be updated by hand whenever that page is next revised.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions