-
Notifications
You must be signed in to change notification settings - Fork 443
Resolve boolean in isAvailable to agree with TypeScript API
#3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! could you also add a small changefile please? (check .changes dir for examples) |
Package Changes Through 5882596There are 8 changes which include log with minor, log-js with minor, nfc with minor, nfc-js with minor, updater with minor, updater-js with minor, upload with minor, upload-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
i mean, the rust code could be updated as well, i think it should support this as well no? |
It absolutely can, after re-reading the original issue where it was suggested to update the TypeScript, I looked at that approach and it made for fewer changes, and only impacts TS usage. The original approach would have affected every |
Description: Updates native plugins for Android / iOS to resolve a simple boolean in the
isAvailable()functions of the NFC pluginFixes: #2830
Tested: iOS / Android simulators; iPhone 8, Pixel 10