fix(clippy): satisfy workspace all-target build gate Refs #1769

Author: Alex

crates/terraphim_config/src/project.rs

@@ -170,10 +170,10 @@ mod tests {
         let temp = TempDir::new().unwrap();
         let real = temp.path().join("real");
         let linked = temp.path().join("linked");
-        fs::create_dir_all(&real.join(".terraphim")).unwrap();
-        fs::create_dir_all(&real.join("src")).unwrap();
+        fs::create_dir_all(real.join(".terraphim")).unwrap();
+        fs::create_dir_all(real.join("src")).unwrap();
         std::os::unix::fs::symlink(&real, &linked).unwrap();
-        let canonical = std::fs::canonicalize(&real.join(".terraphim")).unwrap();
+        let canonical = std::fs::canonicalize(real.join(".terraphim")).unwrap();
         let result = discover(Some(&linked.join("src"))).unwrap();
         assert_eq!(result, Some(canonical));
     }

crates/terraphim_orchestrator/src/lib.rs

@@ -9779,17 +9779,12 @@ sfia_skills = [{ code = "TEST", name = "Testing", level = 4, description = "Desi
             }
         }
 
-        let dump = match std::fs::read_to_string(&dump_path) {
-            Ok(dump) => dump,
-            Err(e) => {
-                assert!(
-                    false,
-                    "env dump not written to {}: {e}",
-                    dump_path.display()
-                );
-                String::new()
-            }
-        };
+        assert!(
+            dump_path.exists(),
+            "env dump not written to {}",
+            dump_path.display()
+        );
+        let dump = std::fs::read_to_string(&dump_path).expect("env dump should be readable");
         assert!(
             dump.contains("ADF_PR_NUMBER=641"),
             "ADF_PR_NUMBER missing from dump:\n{dump}"

crates/terraphim_orchestrator/src/project_adf.rs

@@ -327,7 +327,7 @@ task = "Run safety checks"
     fn discover_and_load_returns_none_when_no_adf_toml() {
         let tmp = TempDir::new().unwrap();
         fs::create_dir_all(tmp.path().join(".terraphim")).unwrap();
-        let result = ProjectAdfConfig::discover_and_load(&tmp.path()).unwrap();
+        let result = ProjectAdfConfig::discover_and_load(tmp.path()).unwrap();
         assert!(result.is_none());
     }