Fix log line to not be fmt-styled#730
Merged
rdimitrov merged 1 commit intoMay 15, 2026
Merged
Conversation
We've been seeing `Failed to verify %s with key ID %s` a bunch in the logs from a service of ours that's consuming a TUF root, and it's a bit confusing to see what appears to be a `fmt`-style line that isn't actually `fmt`ed. This PR changes that `log.Info` call to work like the one a bit below it for when a key ID is verified for the role. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
There was a problem hiding this comment.
Pull request overview
Fixes a misleading log statement in VerifyDelegate that used fmt-style format specifiers (%s) with log.Info, which doesn't perform string formatting. The line is updated to use structured key/value logging, consistent with the success-case log call immediately below it.
Changes:
- Replace
log.Info("Failed to verify %s with key ID %s", delegatedRole, keyID)with structured key/value form matching the neighboring success log.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing
Failed to verify %s with key ID %sa bunch in the logs from a service of ours that's consuming a TUF root, and it's a bit confusing to see what appears to be afmt-style line that isn't actuallyfmted. This PR changes thatlog.Infocall to work like the one a bit below it for when a key ID is verified for the role.