fix: no ignore file will filter nothing (#280)

Author: tianhaoz95

.github/workflows/merge.yml

@@ -14,5 +14,7 @@ jobs:
         uses: actions/checkout@v1
       - name: Run current implementation
         uses: ./
+        env:
+          RRLOG: "true"
         with:
           token: ${{ secrets.TEST_GITHUB_TOKEN }}

.readmeignore

@@ -327,14 +327,14 @@ exports.getReadmeIgnoreList = getReadmeIgnoreList;
 function getLintFileList(workspaceDir) {
     // TODO(tianhaoz95): add test for this.
     const readmeIgnoreFilename = path_1.default.join(workspaceDir, "/.readmeignore");
-    const ignoreList = getReadmeIgnoreList(readmeIgnoreFilename);
+    let ignoreList = getReadmeIgnoreList(readmeIgnoreFilename);
     rrlog("ignore list found: " + JSON.stringify(ignoreList));
     const rawWorkspaceFiles = listFiles(workspaceDir);
     rrlog("rawWorkspaceFiles size: " + rawWorkspaceFiles.length.toString());
     if (ignoreList.length === 0) {
         // match with empty ignorelist will return empty list, so just return
         rrlog("ignorelist is empty, proceed with all markdown files");
-        return rawWorkspaceFiles;
+        ignoreList = ["!**/node_modules/**/*"];
     }
     const workspaceFiles = ignoreFiles(rawWorkspaceFiles, ignoreList);
     rrlog("workspaceFiles size: " + workspaceFiles.length.toString());

lib/util.js

@@ -306,14 +306,14 @@ export function getReadmeIgnoreList(filename: string): string[] {
 export function getLintFileList(workspaceDir: string): string[] {
   // TODO(tianhaoz95): add test for this.
   const readmeIgnoreFilename = path.join(workspaceDir, "/.readmeignore");
-  const ignoreList = getReadmeIgnoreList(readmeIgnoreFilename);
+  let ignoreList = getReadmeIgnoreList(readmeIgnoreFilename);
   rrlog("ignore list found: " + JSON.stringify(ignoreList));
   const rawWorkspaceFiles = listFiles(workspaceDir);
   rrlog("rawWorkspaceFiles size: " + rawWorkspaceFiles.length.toString());
   if (ignoreList.length === 0) {
     // match with empty ignorelist will return empty list, so just return
     rrlog("ignorelist is empty, proceed with all markdown files");
-    return rawWorkspaceFiles;
+    ignoreList = ["!**/node_modules/**/*"];
   }
   const workspaceFiles = ignoreFiles(rawWorkspaceFiles, ignoreList);
   rrlog("workspaceFiles size: " + workspaceFiles.length.toString());