Deprecate lag argument in initial_time_split and update NEWS #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepted GitHub format suggestion. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
and restore functionality for now
test deprecation warning separately, suppress otherwise
plus a little linting by air
Member
|
@bjornkallerud Thank you for your contribution! I hope you had a fun tidy dev day! I've changed it a bit because we don't immediately pull the rug on users and remove functionality, but rather warn in different stages. |
Contributor
Author
|
This makes sense, @hfrick, thank you for the explanation! Appreciate the learning opportunity and looking forward to contributing more in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447.