expr_substitute() does substitute double sided formula (#5915)

* expr_substitute() does substitute double sided formula

Author: romainfrancois

R/utils.r

@@ -145,7 +145,7 @@ expr_substitute <- function(expr, old, new) {
 node_walk_replace <- function(node, old, new) {
   while (!is_null(node)) {
     switch(typeof(node_car(node)),
-      language = if (!is_call(node_car(node), c("~", "function"))) node_walk_replace(node_cdar(node), old, new),
+      language = if (!is_call(node_car(node), c("~", "function")) || is_call(node_car(node), "~", n = 2)) node_walk_replace(node_cdar(node), old, new),
       symbol = if (identical(node_car(node), old)) node_poke_car(node, new)
     )
     node <- node_cdr(node)

revdep/README.md

@@ -1,34 +1,34 @@
 # Revdeps
 
-## Failed to check (18)
+## Failed to check (21)
 
 |package        |version |error |warning |note |
 |:--------------|:-------|:-----|:-------|:----|
 |bayesdfa       |1.1.0   |1     |        |     |
 |CausalImpact   |?       |      |        |     |
 |CB2            |?       |      |        |     |
 |cbar           |?       |      |        |     |
-|CGPfunctions   |?       |      |        |     |
-|crossmap       |?       |      |        |     |
 |diceR          |?       |      |        |     |
+|glmmfields     |0.1.4   |1     |        |     |
+|loon.shiny     |?       |      |        |     |
 |MarketMatching |?       |      |        |     |
+|metagam        |?       |      |        |     |
+|mlbstatsR      |0.1.0   |1     |        |     |
+|pencal         |?       |      |        |     |
+|rabhit         |?       |      |        |     |
 |raw            |?       |      |        |     |
 |rmdcev         |1.2.4   |1     |        |     |
 |rstap          |1.0.3   |1     |        |     |
 |scoper         |?       |      |        |     |
-|SimplyAgree    |?       |      |        |     |
 |SynthETIC      |?       |      |        |     |
 |tigger         |?       |      |        |     |
 |trackr         |?       |      |        |     |
 |vivid          |?       |      |        |     |
 |wrswoR         |?       |      |        |     |
 
-## New problems (4)
+## New problems (1)
 
-|package                              |version |error    |warning |note     |
-|:------------------------------------|:-------|:--------|:-------|:--------|
-|[finreportr](problems.md#finreportr) |1.0.2   |1 __+1__ |        |         |
-|[MoMPCA](problems.md#mompca)         |1.0.1   |1        |        |1 __+1__ |
-|[SwimmeR](problems.md#swimmer)       |0.10.0  |__+1__   |        |         |
-|[xray](problems.md#xray)             |0.2     |__+1__   |        |         |
+|package                  |version |error  |warning |note |
+|:------------------------|:-------|:------|:-------|:----|
+|[imfr](problems.md#imfr) |0.1.9.1 |__+1__ |        |     |
 

revdep/cran.md

@@ -1,42 +1,36 @@
 ## revdepcheck results
 
-We checked 2131 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+We checked 2518 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 4 new problems
- * We failed to check 18 packages
+ * We saw 1 new problems
+ * We failed to check 21 packages
 
 Issues with CRAN packages are summarised below.
 
 ### New problems
 (This reports the first line of each new failure)
 
-* finreportr
-  checking examples ... ERROR
-
-* MoMPCA
-  checking dependencies in R code ... NOTE
-
-* SwimmeR
+* imfr
   checking tests ... ERROR
 
-* xray
-  checking examples ... ERROR
-
 ### Failed to check
 
 * bayesdfa       (NA)
 * CausalImpact   (NA)
 * CB2            (NA)
 * cbar           (NA)
-* CGPfunctions   (NA)
-* crossmap       (NA)
 * diceR          (NA)
+* glmmfields     (NA)
+* loon.shiny     (NA)
 * MarketMatching (NA)
+* metagam        (NA)
+* mlbstatsR      (NA)
+* pencal         (NA)
+* rabhit         (NA)
 * raw            (NA)
 * rmdcev         (NA)
 * rstap          (NA)
 * scoper         (NA)
-* SimplyAgree    (NA)
 * SynthETIC      (NA)
 * tigger         (NA)
 * trackr         (NA)