Clean up from review

Co-authored-by: Jo <[email protected]>

Author: treysp

sqlglot/dialects/duckdb.py

@@ -304,7 +304,7 @@ def _escape_regex_metachars(
         "]": "\\]",
     }
 
-    if isinstance(delimiters, exp.Literal) and delimiters.is_string:
+    if delimiters.is_string:
         literal_value = delimiters.this
         escaped_literal = "".join(REGEX_LITERAL_ESCAPES.get(ch, ch) for ch in literal_value)
         return self.sql(exp.Literal.string(escaped_literal))

sqlglot/generator.py

@@ -5411,13 +5411,12 @@ def uuid_sql(self, expression: exp.Uuid) -> str:
         return uuid_func_sql
 
     def initcap_sql(self, expression: exp.Initcap) -> str:
-        delimiters = expression.args.get("expression")
+        delimiters = expression.expression
         delimiters_sql = None
 
         # do not generate delimiters arg if we are round-tripping from default delimiters
         if (
             delimiters
-            and isinstance(delimiters, exp.Literal)
             and delimiters.is_string
             and delimiters.this == self.dialect.INITCAP_DEFAULT_DELIMITER_CHARS
         ):

tests/dialects/test_dialect.py

@@ -4326,7 +4326,7 @@ def duckdb_regex_literal_sql(delimiters: str) -> str:
             return exp.Literal.string(escaped_literal).sql("duckdb")
 
         # default delimiters not present in roundtrip
-        for dialect in delimiter_chars.keys():
+        for dialect in delimiter_chars:
             with self.subTest(
                 f"Testing INITCAP roundtrips for {dialect or 'default'} dialect without default delimiters included"
             ):