dvc: Drop checkpoint. (#667)

* dvc: Drop checkpoint.

Leftover when upgradint to DVC 3.0

* Drop checkpoint test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Dave Berenbaum <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 3 people

src/dvclive/dvc.py

@@ -4,7 +4,6 @@
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, List, Optional
 
-from dvclive import env
 from dvclive.plots import Image, Metric
 from dvclive.serialize import dump_yaml
 from dvclive.utils import StrPath
@@ -14,9 +13,6 @@
     from dvc.stage import Stage
 
 
-_CHECKPOINT_SLEEP = 0.1
-
-
 def _dvc_dir(dirname: StrPath) -> str:
     return os.path.join(dirname, ".dvc")
 
@@ -60,21 +56,6 @@ def _write_file(file: str, contents=""):
         os.fsync(fobj.fileno())
 
 
-def make_checkpoint():
-    from time import sleep
-
-    root_dir = _find_dvc_root()
-    if not root_dir:
-        return
-
-    signal_file = os.path.join(root_dir, ".dvc", "tmp", env.DVC_CHECKPOINT)
-
-    _write_file(signal_file)
-
-    while os.path.exists(signal_file):
-        sleep(_CHECKPOINT_SLEEP)
-
-
 def get_dvc_repo() -> Optional["Repo"]:
     from dvc.exceptions import NotDvcRepoError
     from dvc.repo import Repo

src/dvclive/live.py

@@ -15,7 +15,6 @@
     find_overlapping_stage,
     get_dvc_repo,
     get_random_exp_name,
-    make_checkpoint,
     make_dvcyaml,
     mark_dvclive_only_ended,
     mark_dvclive_only_started,
@@ -291,7 +290,6 @@ def next_step(self):
             self.make_dvcyaml()
 
         self.make_report()
-        self.make_checkpoint()
         self.step += 1
 
     def log_metric(
@@ -565,10 +563,6 @@ def end(self):
         else:
             self.make_report()
 
-    def make_checkpoint(self):
-        if env2bool(env.DVC_CHECKPOINT):
-            make_checkpoint()
-
     def read_step(self):
         if Path(self.metrics_file).exists():
             latest = self.read_latest()

tests/test_main.py

@@ -411,36 +411,6 @@ def test_context_manager_skips_end_calls(tmp_dir):
     assert (tmp_dir / live.metrics_file).exists()
 
 
-@pytest.mark.parametrize("dvc_root", [True, False])
-@pytest.mark.parametrize("set_env", [True, False])
-def test_create_checkpoint_file(tmp_dir, monkeypatch, dvc_root, set_env, mocker):
-    if dvc_root:
-        (tmp_dir / ".dvc" / "tmp").mkdir(parents=True)
-    if set_env:
-        monkeypatch.setenv(env.DVC_CHECKPOINT, "1")
-
-    dvclive = Live()
-
-    native_exists = os.path.exists
-
-    def checkpoint_never_exists(path):
-        # we need that to avoid waiting for dvc process to remove file
-        if path.endswith(env.DVC_CHECKPOINT):
-            return False
-
-        return native_exists(path)
-
-    with mocker.patch(
-        "dvclive.dvc.os.path.exists", side_effect=checkpoint_never_exists
-    ):
-        dvclive.make_checkpoint()
-
-    if dvc_root and set_env:
-        assert native_exists(os.path.join(".dvc", "tmp", env.DVC_CHECKPOINT))
-    else:
-        assert not native_exists(os.path.join(".dvc", "tmp", env.DVC_CHECKPOINT))
-
-
 @pytest.mark.vscode()
 @pytest.mark.parametrize("dvc_root", [True, False])
 def test_vscode_dvclive_only_signal_file(tmp_dir, dvc_root, mocker):