Skip to content

Add more principles. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add more principles. #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,18 @@ package.json
package-lock.json
```

### 💩 Do not write what you did in commit msg
_Good 👍🏻_


- 1
- 1
- fix

_Bad 👎🏻_

- fix(xxx): Fix a bug where the login button was disabled incorrectly.

### 💩 Always name your boolean value a `flag`

Leave the space for your colleagues to think what the boolean value means.
Expand Down
12 changes: 12 additions & 0 deletions README.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,18 @@ package.json
package-lock.json
```

### 💩 不要在commit msg写明白你做了什么
_Good 👍🏻_


- 1
- 1
- 修改

_Bad 👎🏻_

- fix(xxx): 复了登录按钮被错误禁用的 bug

### 💩 函数长的比短的好

不要把程序逻辑分成可读的部分。如果IDE的搜索停止，而您无法找到所需的文件或函数，该怎么办?
Expand Down