refactor: clean up bridge and connection modules

- Removed unused DiscoverRequest and DiscoverResponse from `bridge.py`.
- Simplified exception handling in `bridge.py` and `connection.py`.
- Updated type hints in `suite_leasing.py` for better clarity.
- Refactored `find_revit_path` to use `Path` for file existence checks in `discovery.py`.
- Cleaned up commented-out code and improved overall readability.

Author: trgiangv

src/revitdevtool_pytest/bridge.py

@@ -13,7 +13,6 @@
 from typing import Any, Callable
 
 from .constants import (
-    BRIDGE_METHOD_TESTS_DISCOVER,
     BRIDGE_METHOD_TESTS_RUN,
     BRIDGE_MSG_TYPE_NOTIFICATION,
     DEFAULT_CONNECT_TIMEOUT_MS,
@@ -24,8 +23,6 @@
     BridgeRequest,
     BridgeResponse,
     CollectionError,
-    DiscoverRequest,
-    DiscoverResponse,
     RunRequest,
     RunResponse,
 )
@@ -107,25 +104,6 @@ def connected(self) -> bool:
 
     # -- Public RPC methods -------------------------------------------------
 
-    def discover_tests(
-        self,
-        workspace_root: str,
-        test_root: str,
-        *,
-        pytest_args: list[str] | None = None,
-        timeout_s: float = DEFAULT_TEST_TIMEOUT_S,
-    ) -> DiscoverResponse:
-        request = DiscoverRequest(
-            workspace_root=workspace_root,
-            test_root=test_root,
-            pytest_args=pytest_args or [],
-        )
-        response = self._request(
-            BridgeRequest(method=BRIDGE_METHOD_TESTS_DISCOVER, params=request.to_params()),
-            timeout_s,
-        )
-        return _parse_discover_response(response)
-
     def run_tests(
         self,
         workspace_root: str,
@@ -207,20 +185,6 @@ def _read_exact(self, count: int, timeout_s: float) -> bytes:
 # ---------------------------------------------------------------------------
 
 
-def _parse_discover_response(response: BridgeResponse) -> DiscoverResponse:
-    if response.is_error:
-        return DiscoverResponse(
-            collection_errors=(CollectionError(message=response.error_message),),
-        )
-    if isinstance(response.result, dict):
-        return DiscoverResponse.from_dict(response.result)
-    return DiscoverResponse(
-        collection_errors=(
-            CollectionError(message=f"Unexpected response: {response.result}"),
-        ),
-    )
-
-
 def _parse_run_response(response: BridgeResponse) -> RunResponse:
     if response.is_error:
         return RunResponse(

src/revitdevtool_pytest/connection.py

@@ -218,7 +218,7 @@ def _try_reconnect_leased(
         store.clear_suite(suite_key)
         return None, False
 
-    bridge, _ = _connect_first_available([leased_instance])
+    bridge, _, _ = _connect_first_available([leased_instance])
     if bridge is not None:
         store.assign(suite_key, suite_path, leased_instance)
         log.info(
@@ -238,7 +238,7 @@ def _connect_and_lease(
     store: SuiteLeaseStore | None,
     label: str,
 ) -> tuple[RevitBridge | None, ConnectionError | None]:
-    bridge, selected, connect_error = _connect_first_available_with_instance(instances)
+    bridge, selected, connect_error = _connect_first_available(instances)
     if bridge is None or selected is None:
         return None, connect_error
     if store:
@@ -252,18 +252,6 @@ def _connect_and_lease(
 
 def _connect_first_available(
     instances: list[RevitInstance],
-) -> tuple[RevitBridge | None, ConnectionError | None]:
-    last_error: ConnectionError | None = None
-    for instance in instances:
-        try:
-            return connect_pipe(instance.pipe_name), None
-        except ConnectionError as exc:
-            last_error = exc
-    return None, last_error
-
-
-def _connect_first_available_with_instance(
-    instances: list[RevitInstance],
 ) -> tuple[RevitBridge | None, RevitInstance | None, ConnectionError | None]:
     last_error: ConnectionError | None = None
     for instance in instances:

src/revitdevtool_pytest/discovery.py

@@ -73,27 +73,6 @@ def find_revit_path(version: int) -> str | None:
     return default if os.path.isfile(default) else None
 
 
-def launch_revit(
-    version: int,
-    wait_timeout_s: float = DEFAULT_LAUNCH_TIMEOUT_S,
-) -> RevitInstance | None:
-    """Start Revit with ``/nosplash`` and wait for its Named Pipe to appear.
-
-    Returns the discovered ``RevitInstance``, or ``None`` on timeout.
-    Raises ``FileNotFoundError`` if the requested version is not installed.
-    """
-    exe_path = find_revit_path(version)
-    if exe_path is None:
-        raise FileNotFoundError(f"Revit {version} installation not found.")
-
-    subprocess.Popen(  # noqa: S603
-        [exe_path, REVIT_NOSPLASH],
-        creationflags=subprocess.DETACHED_PROCESS,
-    )
-
-    return wait_for_revit_pipe(version, timeout_s=wait_timeout_s)
-
-
 def start_revit(version: int) -> int:
     """Start Revit with ``/nosplash`` and return the spawned process id."""
     exe_path = find_revit_path(version)

src/revitdevtool_pytest/reporting.py

@@ -266,7 +266,7 @@ def _build_longrepr(
     if outcome == OUTCOME_FAILED and (result.message or result.traceback):
         return result.traceback if result.traceback else result.message
     if outcome == OUTCOME_SKIPPED:
-        return ("", -1, f"Skipped: {result.message}" if result.message else "Skipped")
+        return "", -1, f"Skipped: {result.message}" if result.message else "Skipped"
     return None
 
 

src/revitdevtool_pytest/suite_leasing.py

@@ -57,36 +57,6 @@ def __init__(self, state_file: Path | None = None) -> None:
         self._state_file = state_file or _STATE_FILE
         self._leases = self._load_leases()
 
-    def resolve_existing(
-        self,
-        suite_key: str,
-        suite_path: str,
-        instances: list[RevitInstance],
-    ) -> RevitInstance | None:
-        active_by_pid = {instance.process_id: instance for instance in instances}
-        self._prune_stale(active_by_pid)
-
-        lease = self._leases.get(suite_key)
-        if lease is None:
-            return None
-
-        active = active_by_pid.get(lease.process_id)
-        if active is None:
-            self._leases.pop(suite_key, None)
-            self._save_leases()
-            return None
-
-        self._leases[suite_key] = SuiteLease(
-            suite_key=suite_key,
-            suite_path=suite_path,
-            pipe_name=active.pipe_name,
-            process_id=active.process_id,
-            assigned_at=lease.assigned_at,
-            last_seen_at=time.time(),
-        )
-        self._save_leases()
-        return active
-
     def find_free(
         self,
         suite_key: str,
@@ -119,10 +89,6 @@ def assign(
         )
         self._save_leases()
 
-    def get_suite_process_id(self, suite_key: str) -> int | None:
-        lease = self._leases.get(suite_key)
-        return None if lease is None else lease.process_id
-
     def get_suite_lease(self, suite_key: str) -> SuiteLease | None:
         return self._leases.get(suite_key)