Skip to content

BUG: errors handling unicode emoji #39

Description

@veesahni

Route Node Version: 4.1.1
Node Version: 12.16.3

Reproducible code:

      const rootNode = new RouteNode('', '', [new RouteNode('users', '/users?:q')])
      console.log(rootNode.buildPath('users', { q: 'test漢字' }))
      // outputs: /users?q=test%E6%BC%A2%E5%AD%97
      console.log(rootNode.buildPath('users', { q: '60ad50🚀' }))
      // outputs: /users?q=60ad50%F0%9F%9A%80
      rootNode.setPath('/')
      console.log(rootNode.buildPath('users', { q: 'test漢字' }))
      // outputs: /users?q=test%E6%BC%A2%E5%AD%97
      console.log(rootNode.buildPath('users', { q: '60ad50🚀' }))
      // EXCEPTION: Uncaught URIError: URI malformed

Discussion:

  • Library seems to handle international unicode characters just fine but fails on emoji
  • Additionally, it only fails if path is set

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions