Skip to content

issue #174: Fix incomplete AAR header if there is no own AR header #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
futatuki wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

issue #174: Fix incomplete AAR header if there is no own AR header #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef5a6d0
issue #174: Fix incomplete AAR header if there is no own AR header
futatuki Sep 11, 2024
4c0d4a4
Correctly indicate no auth result in AAR
flowerysong Oct 2, 2024
98151b3
arc_getseal: Clarify that ar can be NULL in the function description …
futatuki Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions libopenarc/arc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3070,7 +3070,8 @@ arc_set_cv(ARC_MESSAGE *msg, ARC_CHAIN cv)
** domain -- domain name
** key -- secret key, printable
** keylen -- key length
** ar -- Authentication-Results to be enshrined
** ar -- Authentication-Results to be enshrined. It can be NULL,
** which means no results.
**
** Return value:
** An ARC_STAT_* constant.
Expand Down Expand Up @@ -3213,8 +3214,12 @@ arc_getseal(ARC_MESSAGE *msg, ARC_HDRFIELD **seal, char *authservid,
arc_dstring_printf(dstr, "ARC-Authentication-Results:i=%u; %s",
msg->arc_nsets + 1,
msg->arc_authservid);
if (ar != NULL)
if (ar == NULL) {
/* no-result per RFC 8601 2.2 */
arc_dstring_printf(dstr, "; none");
} else {
arc_dstring_printf(dstr, "; %s", (char *) ar);
}

status = arc_parse_header_field(msg, arc_dstring_get(dstr),
arc_dstring_len(dstr), &h);
Expand Down
3 changes: 2 additions & 1 deletion libopenarc/arc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,8 @@ extern void arc_set_cv __P((ARC_MESSAGE *, ARC_CHAIN));
** domain -- domain name
** key -- secret key
** keylen -- key length
** ar -- Authentication-Results to be enshrined
** ar -- Authentication-Results to be enshrined. It can be NULL,
** which means no results.
**
** Return value:
** An ARC_STAT_* constant.
Expand Down
2 changes: 1 addition & 1 deletion openarc/openarc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3768,7 +3768,7 @@ mlfi_eom(SMFICTX *ctx)
conf->conf_keylen,
arcf_dstring_len(afc->mctx_tmpstr) > 0
? arcf_dstring_get(afc->mctx_tmpstr)
: NULL);
: "none");
if (status != ARC_STAT_OK)
{
if (conf->conf_dolog)
Expand Down