Merge pull request #4 from trustpilot/add-booleans

Add booleans

Author: sloev

.gitignore

@@ -0,0 +1,4 @@
+__pycache__
+.python-version
+.cache
+.pytest_cache

HISTORY.rst

@@ -15,4 +15,9 @@ History
 1.1.0(2018-03-01)
 ------------------
 
-* request can be renamed and even type-annotated
+* request can be renamed and even type-annotated
+
+1.2.0 (2018-03-01)
+------------------
+
+* added support for boolean parameters

sanicargs/__init__.py

@@ -15,21 +15,34 @@ def __parse_datetime(str):
     # attempt full date time, but tolerate just a date
     try:
         return datetime.datetime.strptime(str, '%Y-%m-%dT%H:%M:%S')
-    except:
+    except Exception:
         pass
     return datetime.datetime.strptime(str, '%Y-%m-%d')
 
+
 def __parse_date(str):
     return datetime.datetime.strptime(str, '%Y-%m-%d').date()
 
+
+def __parse_bool(str):
+    lower = str.lower()
+    if lower == 'true':
+        return True
+    if lower == 'false':
+        return False
+    raise ValueError("Can't parse {} as boolean".format(str))
+
+
 __type_deserializers = {
+    bool: __parse_bool,
     int: int,
     str: str,
     datetime.datetime: __parse_datetime,
     datetime.date: __parse_date,
     List[str]: lambda s: s.split(',')
 }
 
+
 def parse_query_args(func):
     '''parses query args and validates, deserializes them
     VERY IMPORTANT!:
@@ -82,4 +95,4 @@ async def inner(request, *old_args, **route_parameters):
             })
             return abort(400, 'Bad or missing value for %s' % name)
         return await func(request, **kwargs)
-    return inner
+    return inner

sanicargs/__version__.py

@@ -1 +1 @@
-__version__ = '1.1.0'
+__version__ = '1.2.0'

tests/test_sanicargs.py

@@ -24,6 +24,11 @@ async def test_int(request, test: int):
     async def test_str(request, test: str):
         return response.json({'test': test})
 
+    @app.route("/bool", methods=['GET'])
+    @parse_query_args
+    async def test_bool(request, test: bool):
+        return response.json({'test': test})
+
     @app.route("/datetime", methods=['GET'])
     @parse_query_args
     async def test_datetime(request, test: datetime.datetime):
@@ -90,6 +95,23 @@ async def test_parse_int_fail(test_cli):
     assert resp.status == 400
 
 
+async def test_parse_bool_true_success(test_cli):
+    resp = await test_cli.get('/bool?test=true')
+    assert resp.status == 200
+    resp_json = await resp.json()
+    assert resp_json == {'test': True }
+
+async def test_parse_bool_false_success(test_cli):
+    resp = await test_cli.get('/bool?test=false')
+    assert resp.status == 200
+    resp_json = await resp.json()
+    assert resp_json == {'test': False }
+
+async def test_parse_bool_fail(test_cli):
+    resp = await test_cli.get('/bool?test=not an bool')
+    assert resp.status == 400
+
+
 async def test_parse_str_success(test_cli):
     resp = await test_cli.get('/str?test=hello')
     assert resp.status == 200