Merge branch 'dev'

Author: tw93

CLAUDE.md

@@ -57,12 +57,14 @@ pnpm run dev        # Development with hot reload
 - **CLI Tool** (`bin/`): Main entry point, builders, options processing
 - **Tauri App** (`src-tauri/`): Rust application, window/tray management, injection logic
 - **Config Files**: `pake.json`, `tauri.conf.json`, platform-specific configs
+- **Injection System** (`src-tauri/src/inject/event.js`): Custom event handlers, shortcuts, downloads, notifications
 
 ## Documentation Guidelines
 
 - **Main README**: Common parameters only
 - **CLI Documentation** (`docs/cli-usage.md`): ALL parameters with examples
 - **Rare parameters**: Full docs in CLI usage, minimal in main README
+- **NO technical documentation files**: Do not create separate technical docs, design docs, or implementation notes - keep technical details in memory/conversation only
 
 ## Platform Specifics
 

bin/builders/BaseBuilder.ts

@@ -123,14 +123,12 @@ export default abstract class BaseBuilder {
         `cd "${npmDirectory}" && ${packageManager} install${registryOption}${peerDepsOption}`,
         timeout,
         buildEnv,
-        this.options.debug,
       );
     } else {
       await shellExec(
         `cd "${npmDirectory}" && ${packageManager} install${peerDepsOption}`,
         timeout,
         buildEnv,
-        this.options.debug,
       );
     }
     spinner.succeed(chalk.green('Package installed!'));
@@ -169,11 +167,24 @@ export default abstract class BaseBuilder {
       ...(process.env.NO_STRIP && { NO_STRIP: process.env.NO_STRIP }),
     };
 
+    // Warn users about potential AppImage build failures on modern Linux systems.
+    // The linuxdeploy tool bundled in Tauri uses an older strip tool that doesn't
+    // recognize the .relr.dyn section introduced in glibc 2.38+.
+    if (process.platform === 'linux' && this.options.targets === 'appimage') {
+      if (!buildEnv.NO_STRIP) {
+        logger.warn(
+          '⚠ Building AppImage on Linux may fail due to strip incompatibility with glibc 2.38+',
+        );
+        logger.warn(
+          '⚠ If build fails, retry with: NO_STRIP=1 pake <url> --targets appimage',
+        );
+      }
+    }
+
     await shellExec(
       `cd "${npmDirectory}" && ${this.getBuildCommand(packageManager)}`,
       this.getBuildTimeout(),
       buildEnv,
-      this.options.debug,
     );
 
     // Copy app
@@ -280,6 +291,12 @@ export default abstract class BaseBuilder {
       fullCommand += ` --target ${target}`;
     }
 
+    // Enable verbose output in debug mode to help diagnose build issues.
+    // This provides detailed logs from Tauri CLI and bundler tools.
+    if (this.options.debug) {
+      fullCommand += ' --verbose';
+    }
+
     return fullCommand;
   }
 

bin/builders/LinuxBuilder.ts

@@ -78,6 +78,13 @@ export default class LinuxBuilder extends BaseBuilder {
       fullCommand += ` --features ${features.join(',')}`;
     }
 
+    // Enable verbose output for AppImage builds when debugging or PAKE_VERBOSE is set.
+    // AppImage builds often fail with minimal error messages from linuxdeploy,
+    // so verbose mode helps diagnose issues like strip failures and missing dependencies.
+    if (this.options.targets === 'appimage' && (this.options.debug || process.env.PAKE_VERBOSE)) {
+      fullCommand += ' --verbose';
+    }
+
     return fullCommand;
   }
 

bin/cli.ts

@@ -99,6 +99,11 @@ program
       .default(DEFAULT.alwaysOnTop)
       .hideHelp(),
   )
+  .addOption(
+    new Option('--maximize', 'Start window maximized')
+      .default(DEFAULT.maximize)
+      .hideHelp(),
+  )
   .addOption(
     new Option('--dark-mode', 'Force Mac app to use dark mode')
       .default(DEFAULT.darkMode)
@@ -164,6 +169,11 @@ program
       .default(DEFAULT.multiInstance)
       .hideHelp(),
   )
+  .addOption(
+    new Option('--start-to-tray', 'Start app minimized to tray')
+      .default(DEFAULT.startToTray)
+      .hideHelp(),
+  )
   .addOption(
     new Option('--installer-language <string>', 'Installer language')
       .default(DEFAULT.installerLanguage)

bin/defaults.ts

@@ -5,6 +5,7 @@ export const DEFAULT_PAKE_OPTIONS: PakeCliOptions = {
   height: 780,
   width: 1200,
   fullscreen: false,
+  maximize: false,
   resizable: true,
   hideTitleBar: false,
   alwaysOnTop: false,
@@ -28,6 +29,7 @@ export const DEFAULT_PAKE_OPTIONS: PakeCliOptions = {
   enableDragDrop: false,
   keepBinary: false,
   multiInstance: false,
+  startToTray: false,
 };
 
 // Just for cli development

bin/helpers/merge.ts

@@ -49,6 +49,7 @@ export async function mergeConfig(
     width,
     height,
     fullscreen,
+    maximize,
     hideTitleBar,
     alwaysOnTop,
     appVersion,
@@ -71,6 +72,7 @@ export async function mergeConfig(
     wasm,
     enableDragDrop,
     multiInstance,
+    startToTray,
   } = options;
 
   const { platform } = process;
@@ -81,6 +83,7 @@ export async function mergeConfig(
     width,
     height,
     fullscreen,
+    maximize,
     resizable,
     hide_title_bar: hideTitleBar,
     activation_shortcut: activationShortcut,
@@ -92,6 +95,7 @@ export async function mergeConfig(
     title: title || null,
     enable_wasm: wasm,
     enable_drag_drop: enableDragDrop,
+    start_to_tray: startToTray && showSystemTray,
   };
   Object.assign(tauriConf.pake.windows[0], { url, ...tauriConfWindowOptions });
 

bin/helpers/rust.ts

@@ -83,7 +83,6 @@ export async function installRust() {
       IS_WIN ? rustInstallScriptForWindows : rustInstallScriptForMac,
       300000,
       undefined,
-      true,
     );
     spinner.succeed(chalk.green('✔ Rust installed successfully!'));
     ensureRustEnv();

bin/types.ts

@@ -24,6 +24,9 @@ export interface PakeCliOptions {
   // Whether the window can be fullscreen, default false
   fullscreen: boolean;
 
+  // Start window maximized, default false
+  maximize: boolean;
+
   // Enable immersive header, default false.
   hideTitleBar: boolean;
 
@@ -90,6 +93,9 @@ export interface PakeCliOptions {
 
   // Allow multiple instances, default false (single instance)
   multiInstance: boolean;
+
+  // Start app minimized to tray, default false
+  startToTray: boolean;
 }
 
 export interface PakeAppOptions extends PakeCliOptions {

bin/utils/shell.ts

@@ -5,12 +5,13 @@ export async function shellExec(
   command: string,
   timeout: number = 300000,
   env?: Record<string, string>,
-  showOutput: boolean = false,
 ) {
   try {
     const { exitCode } = await execa(command, {
       cwd: npmDirectory,
-      stdio: showOutput ? 'inherit' : ['inherit', 'pipe', 'inherit'],
+      // Use 'inherit' to show all output directly to user in real-time.
+      // This ensures linuxdeploy and other tool outputs are visible during builds.
+      stdio: 'inherit',
       shell: true,
       timeout,
       env: env ? { ...process.env, ...env } : process.env,
@@ -28,17 +29,27 @@ export async function shellExec(
 
     let errorMsg = `Error occurred while executing command "${command}". Exit code: ${exitCode}. Details: ${errorMessage}`;
 
+    // Provide helpful guidance for common Linux AppImage build failures
+    // caused by strip tool incompatibility with modern glibc (2.38+)
     if (
       process.platform === 'linux' &&
       (errorMessage.includes('linuxdeploy') ||
         errorMessage.includes('appimage') ||
         errorMessage.includes('strip'))
     ) {
       errorMsg +=
-        '\n\nLinux AppImage build error. Try one of these solutions:\n' +
-        '  1. Run with: NO_STRIP=true pake <url> --targets appimage\n' +
-        '  2. Use DEB format instead: pake <url> --targets deb\n' +
-        '  3. See detailed solutions: https://github.com/tw93/Pake/blob/main/docs/faq.md';
+        '\n\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n' +
+        'Linux AppImage Build Failed\n' +
+        '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n\n' +
+        'Cause: Strip tool incompatibility with glibc 2.38+\n' +
+        '       (affects Debian Trixie, Arch Linux, and other modern distros)\n\n' +
+        'Quick fix:\n' +
+        '  NO_STRIP=1 pake <url> --targets appimage --debug\n\n' +
+        'Alternatives:\n' +
+        '  • Use DEB format: pake <url> --targets deb\n' +
+        '  • Update binutils: sudo apt install binutils (or pacman -S binutils)\n' +
+        '  • Detailed guide: https://github.com/tw93/Pake/blob/main/docs/faq.md\n' +
+        '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━';
     }
 
     throw new Error(errorMsg);