-
-
Notifications
You must be signed in to change notification settings - Fork 837
Require Range to be a range in UTFStringCodePoints to improve error messages #3733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@markusicu, should this target main on a new ticket, or 78 maintenance on a reopened ICU-23004? |
@eggrobin is this PR fixing problems, or just "improv[ing] error messages"? @mihnita @richgillam FYI |
markusicu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as an improvement for ICU 79 -- please create an ICU 79 ticket for such improvements
markusicu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create an ICU 79 ticket for this
| */ | ||
| template<typename CP32, UTFIllFormedBehavior behavior, typename Range> | ||
| #if defined(__cpp_lib_ranges) | ||
| requires std::ranges::range<Range> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| requires std::ranges::range<Range> | |
| requires std::ranges::range<Range> |
Suggested by @jmr after seeing the error messages generated by
UTFStringCodePoints<..., char>(which was how this API worked in an earlier draft).TODO: Fill out the checklist below.
Checklist