Fixing fetchRandomArtworkwithuser

Author: andreespirela

README.md

@@ -354,18 +354,20 @@ fetchUserByUsername('t8').then((result) => {
 ### Fetching random artwork with owner information
 
 **Signature**:  
-`fetchRandomArtworkWithUser = async (): Promise<ArtworkOwner>`
+`fetchRandomArtworkWithUser = async (amount?: number): Promise<Array<ArtworkOwner>>`
 
 **Usage**:
 ```typescript
 import { fetchRandomArtworkWithUser } from 'verto-cache-interface';
 
-fetchRandomArtworkWithUser().then((result) => {
-    console.log('Artwork ID ', result.id);
-    console.log('Name ', result.name);
-    console.log('Type ', result.type);
-    console.log('Images ', result.images);
-    console.log('Owner username ', result.owner.username);
+fetchRandomArtworkWithUser().then((arts) => {
+    arts.forEach(result => {
+        console.log('Artwork ID ', result.id);
+        console.log('Name ', result.name);
+        console.log('Type ', result.type);
+        console.log('Images ', result.images);
+        console.log('Owner username ', result.owner.username);
+    });
 })
 ```
 

src/calls/fetch-random-artwork-with-user.ts

@@ -11,24 +11,26 @@ interface ArtworkOwner {
     owner: CommunityContractPeople
 }
 
-export const fetchRandomArtworkWithUser = async (amount?: number): Promise<ArtworkOwner | undefined> => {
-    const artwork = (await fetchRandomArtwork(amount || 1))?.entities?.[0];
+export const fetchRandomArtworkWithUser = async (amount?: number): Promise<Array<ArtworkOwner>> => {
+    const artwork = (await fetchRandomArtwork(amount || 4))?.entities || [];
+    const result: Array<ArtworkOwner> = [];
 
-    if (artwork) {
-        const artworkId = artwork.contractId;
+    for (let artworkElement of artwork) {
+        const artworkId = artworkElement.contractId;
         const artworkState = (await fetchContract(artworkId))?.state;
         if(artworkState) {
-            const owner = await fetchUserByUsername(artwork.lister);
+            const owner = await fetchUserByUsername(artworkElement.lister);
             if(owner) {
-                return {
+                result.push({
                     id: artworkId,
                     name: artworkState.name,
-                    type: artwork.type,
-                    images: (artwork.type === "collection" && artworkState.items.slice(0, 3)) || [],
+                    type: artworkElement.type,
+                    images: (artworkElement.type === "collection" && artworkState?.items?.slice(0, 3)) || [],
                     owner
-                }
+                });
             }
         }
     }
 
+    return result;
 }

src/tests/api.test.ts

@@ -139,14 +139,15 @@ describe("API test", () => {
     });
 
     test("Fetch random artwork with user", async () => {
-        const tokenArtwork = await fetchRandomArtworkWithUser(1);
-        expect(tokenArtwork!.id).not.toBeUndefined();
-        expect(tokenArtwork!.name).not.toBeUndefined();
-        if(tokenArtwork!.type === "collection") {
-            expect(tokenArtwork!.images).not.toBeUndefined();
-            expect(tokenArtwork!.images.length).toBeGreaterThanOrEqual(1);
+        const tokenArtwork = await fetchRandomArtworkWithUser();
+        expect(tokenArtwork.length).toBeGreaterThanOrEqual(4);
+        expect(tokenArtwork[0]!.id).not.toBeUndefined();
+        expect(tokenArtwork[0]!.name).not.toBeUndefined();
+        if(tokenArtwork[0]!.type === "collection") {
+            expect(tokenArtwork[0]!.images).not.toBeUndefined();
+            expect(tokenArtwork[0]!.images.length).toBeGreaterThanOrEqual(1);
         }
-        expect(tokenArtwork!.owner.username).not.toBeUndefined();
+        expect(tokenArtwork[0]!.owner.username).not.toBeUndefined();
     });
 
     test("Fetch artwork metadata", async () => {