fix: close file (#521)

testwill · waybackarchiver · web-flow · commit c8cacd7ee819 · 2024-06-16T08:16:49.000Z
* fix: close file

* Update changelog.md

---------

Co-authored-by: Wayback Archiver &lt;66856220+waybackarchiver@users.noreply.github.com&gt;
diff --git a/cmd/wayback/wayback.go b/cmd/wayback/wayback.go
@@ -143,6 +143,7 @@ func readFromFile(s string) (urls []*url.URL) {
 		if err != nil {
 			return
 		}
+		defer file.Close()
 		scanner := bufio.NewScanner(file)
 		for scanner.Scan() {
 			uri, err := url.Parse(scanner.Text())
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Load the config file always ([#498](https://github.com/wabarc/wayback/pull/498))
 - Signing RPM packages ([#507](https://github.com/wabarc/wayback/pull/507))
+- Fix opened file not closing ([#521](https://github.com/wabarc/wayback/pull/521))
 
 ## [0.19.1] - 2023-03-21
 

Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,7 @@ func readFromFile(s string) (urls []*url.URL) {`
`143`	`143`	`if err != nil {`
`144`	`144`	`return`
`145`	`145`	`}`
	`146`	`+ defer file.Close()`
`146`	`147`	`scanner := bufio.NewScanner(file)`
`147`	`148`	`for scanner.Scan() {`
`148`	`149`	`uri, err := url.Parse(scanner.Text())`