Use new cloud mode setup UI for local -> cloud handoff UI#9653
Open
harryalbert wants to merge 5 commits intoharry/remote-1486-implement-local-cloud-handofffrom
Open
Conversation
This was referenced Apr 30, 2026
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
harryalbert
changed the base branch from
harry/remote-1486-implement-local-cloud-handoff
to
graphite-base/9653
harryalbert
force-pushed
the
harry/remote-1519-make-ui-better-for-local-cloud-handoff
branch
from
ce2f268 to
b0a73ac
Compare
harryalbert
changed the base branch from
graphite-base/9653
to
harry/remote-1486-implement-local-cloud-handoff
harryalbert
force-pushed
the
harry/remote-1519-make-ui-better-for-local-cloud-handoff
branch
from
b0a73ac to
a1189d6
Compare
harryalbert
force-pushed
the
harry/remote-1486-implement-local-cloud-handoff
branch
from
48ed3c0 to
9311573
Compare
harryalbert
force-pushed
the
harry/remote-1519-make-ui-better-for-local-cloud-handoff
branch
from
a1189d6 to
0852c52
Compare
harryalbert
changed the title
harryalbert
changed the title
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR moves local-to-cloud handoff to fork on chip click, pre-populates the new cloud pane with the forked conversation, and reuses cloud-mode setup UI/replay suppression for the handoff flow.
Concerns
- The diff has compile-blocking Rust issues in the handoff session/input-mode path and the
PendingHandoffinitializer. - The setup-command flag is still cleared by restored conversation exchanges, so the handoff pane can leave setup mode before the cloud session's startup commands arrive.
- The submit path can silently no-op if snapshot upload has not produced a cached prep token.
- Manual security pass found no additional security-specific findings in the inlined diff.
Verdict
Found: 2 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
force-pushed
the
harry/remote-1486-implement-local-cloud-handoff
branch
from
9311573 to
eea298a
Compare
harryalbert
force-pushed
the
harry/remote-1519-make-ui-better-for-local-cloud-handoff
branch
from
0852c52 to
53f23d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to use the same new cloud mode setup UI for local -> cloud handoff that we have for regular cloud mode setup. We also want to immediately fork the entire conversation into the new cloud pane before you've actually starting the cloud run.
The main change required to do this was to fork the conversation on-chip-click instead of on-prompt-send (see the corresponding server PR for this issue), as we don't want the forked conversation to get stale if new prompts are sent to the old conversation between clicking the chip and sending a prompt in the cloud mode window.
Screenshots / Videos
https://www.loom.com/share/580624a891d64bec81f9642dda766583
Agent Mode