prevent segmentation violation if request fails

mblaschke · mblaschke · commit 0d4b1e14fa0e · 2021-08-27T19:27:58.000+02:00
Signed-off-by: Markus Blaschke &lt;mblaschke82@gmail.com&gt;
diff --git a/metrics/insights.go b/metrics/insights.go
@@ -54,9 +54,11 @@ func (p *MetricProber) FetchMetricsFromTarget(client *insights.MetricsClient, ta
 		insights.Data,
 		p.settings.MetricNamespace,
 	)
-	p.logger.Debugf("sent request to %s", result.Request.URL.String())
 
 	if err == nil {
+		if result.Request.URL != nil {
+			p.logger.Debugf("sent request to %s", result.Request.URL.String())
+		}
 		ret.Result = &result
 		ret.ResourceID = &target.ResourceId
 	}

Original file line number	Diff line number	Diff line change
`@@ -54,9 +54,11 @@ func (p MetricProber) FetchMetricsFromTarget(client insights.MetricsClient, ta`
`54`	`54`	`insights.Data,`
`55`	`55`	`p.settings.MetricNamespace,`
`56`	`56`	`)`
`57`		`- p.logger.Debugf("sent request to %s", result.Request.URL.String())`
`58`	`57`
`59`	`58`	`if err == nil {`
	`59`	`+ if result.Request.URL != nil {`
	`60`	`+ p.logger.Debugf("sent request to %s", result.Request.URL.String())`
	`61`	`+ }`
`60`	`62`	`ret.Result = &result`
`61`	`63`	`ret.ResourceID = &target.ResourceId`
`62`	`64`	`}`