Logs: adding extra logs for application password card build #22362
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Copilot finished reviewing on behalf of
adalpari
November 20, 2025 11:34
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive logging for the Application Password discovery process and card UI lifecycle to aid in debugging and error tracking. The changes introduce consistent "AP:" log prefixes and replace Android's Log with the app's AppLogWrapper.
Key Changes
- Added structured logging throughout the Application Password flow with "AP:" prefix for easier filtering
- Replaced
android.util.LogwithAppLogWrapperfor consistent logging infrastructure - Added debug logs for card visibility decisions (show/hide scenarios)
- Enhanced error logging with more descriptive messages for failure scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ApplicationPasswordViewModelSlice.kt | Added AppLogWrapper dependency and debug logs for card build/hide decisions during authentication checks |
| ApplicationPasswordLoginHelper.kt | Replaced Android Log with AppLogWrapper, updated all log messages to use "AP:" prefix, and added error logging for invalid credential data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ress/src/main/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelper.kt
Show resolved
Hide resolved
Contributor
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22362-7859ea0 | |
| Commit | 7859ea0 | |
| Direct Download | jetpack-prototype-build-pr22362-7859ea0.apk |
Contributor
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22362-7859ea0 | |
| Commit | 7859ea0 | |
| Direct Download | wordpress-prototype-build-pr22362-7859ea0.apk |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #22362 +/- ##
=======================================
Coverage 39.02% 39.03%
=======================================
Files 2203 2203
Lines 106304 106314 +10
Branches 15057 15057
=======================================
+ Hits 41489 41499 +10
Misses 61326 61326
Partials 3489 3489 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dcalhoun
approved these changes
Nov 20, 2025
adalpari
deleted the
logs/adding-extra-logs-for-Application-Password-card-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding new logs for the Application Password discovery process and the card build.
These changes will help us to track possible errors.
Testing instructions
Just check the code, and check the CI is green