-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reader: Show error description when failing to load posts #25017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29900 | |
| Version | PR #25017 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 55fb233 | |
| Installation URL | 3d4c1udnqoh68 |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29900 | |
| Version | PR #25017 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 55fb233 | |
| Installation URL | 3cdc8hdhe3sfg |
|
kean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but we might want to add some more details if it's a P2 and a A8C account. I'd add something like: "You need to add yourself as a P2 member to view the posts on this device".
|
@kean I thought about copying the same text from the web page when you visit a private P2 without AutoProxxy. But I didn't want to complicate things, considering the existing message mentions "private blog". |
Sounds good. I think it is good enough, and is similar to how the web handles it. |
* Reader: Show error description when failing to load posts Fixes https://linear.app/a8c/issue/CMM-815 * Fix unit tests





Description
Fixes https://linear.app/a8c/issue/CMM-815
After the fix:
Testing instructions
Find a P2 that you are not a member of. Send a post link in that P2 to your test device. Open the link.
BTW, you don't need AutoProxxy to view posts from the app.