Skip to content

Conversation

@crazytonyli
Copy link
Contributor

Description

Fixes https://linear.app/a8c/issue/CMM-815

After the fix:

Testing instructions

Find a P2 that you are not a member of. Send a post link in that P2 to your test device. Open the link.

BTW, you don't need AutoProxxy to view posts from the app.

@crazytonyli crazytonyli added this to the 26.5 ❄️ milestone Nov 25, 2025
@crazytonyli crazytonyli requested review from jkmassel and kean November 25, 2025 01:49
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 25, 2025

1 Warning
⚠️ This PR is assigned to the milestone 26.5 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 25, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29900
VersionPR #25017
Bundle IDcom.jetpack.alpha
Commit55fb233
Installation URL3d4c1udnqoh68
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 25, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29900
VersionPR #25017
Bundle IDorg.wordpress.alpha
Commit55fb233
Installation URL3cdc8hdhe3sfg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@sonarqubecloud
Copy link

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but we might want to add some more details if it's a P2 and a A8C account. I'd add something like: "You need to add yourself as a P2 member to view the posts on this device".

@crazytonyli
Copy link
Contributor Author

@kean I thought about copying the same text from the web page when you visit a private P2 without AutoProxxy. But I didn't want to complicate things, considering the existing message mentions "private blog".

@crazytonyli crazytonyli merged commit 2c5a3c2 into release/26.5 Nov 25, 2025
30 of 32 checks passed
@crazytonyli crazytonyli deleted the bugfix/CMM-815-private-blog branch November 25, 2025 21:32
@kean
Copy link
Contributor

kean commented Nov 25, 2025

@kean I thought about copying the same text from the web page when you visit a private P2 without AutoProxxy. But I didn't want to complicate things, considering the existing message mentions "private blog".

Sounds good. I think it is good enough, and is similar to how the web handles it.

jkmassel pushed a commit that referenced this pull request Nov 27, 2025
* Reader: Show error description when failing to load posts

Fixes https://linear.app/a8c/issue/CMM-815

* Fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants