From b3247acf5d025349c5337329c9f06ae72b4c9546 Mon Sep 17 00:00:00 2001 From: AnonRish Date: Sun, 16 Aug 2026 16:16:44 -0400 Subject: [PATCH] Fix panic on empty user_ids in RetrieveTopKCandidatesRequest --- phoenix/crates/serving/xai-recsys-engine/src/python.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/phoenix/crates/serving/xai-recsys-engine/src/python.rs b/phoenix/crates/serving/xai-recsys-engine/src/python.rs index fa3e6651..bac9e836 100644 --- a/phoenix/crates/serving/xai-recsys-engine/src/python.rs +++ b/phoenix/crates/serving/xai-recsys-engine/src/python.rs @@ -2824,7 +2824,14 @@ impl RecsysRetrievalPredictorImpl { })?; let _in_flight_guard = InFlightGuard::new(); - let user_id = request.user_ids.pop().unwrap(); + let Some(user_id) = request.user_ids.pop() else { + NUM_REQUESTS_REJECTED + .with_label_values(&["invalid_argument", client.as_str()]) + .inc(); + return Err(Status::invalid_argument( + "RetrieveTopKCandidatesRequest.user_ids must not be empty", + )); + }; let sequence = request.sequences.pop(); let topic_entity_ids = request.topic_entity_ids; let topic_filter_mode = request.topic_filter_mode.unwrap_or(0);