Add TestPrestoNativeTvfFunctions

Author: xin-zhang2

presto-hive/src/test/java/com/facebook/presto/hive/HiveQueryRunner.java

@@ -36,7 +36,6 @@
 import com.facebook.presto.tests.tpcds.TpcdsTableName;
 import com.facebook.presto.tpcds.TpcdsPlugin;
 import com.facebook.presto.tpch.TpchPlugin;
-import com.facebook.presto.tvf.TvfPlugin;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
@@ -244,9 +243,9 @@ public static DistributedQueryRunner createQueryRunner(
             metastore = externalMetastore.orElseGet(() -> getFileHiveMetastore(queryRunner));
 
             queryRunner.installPlugin(new HivePlugin(HIVE_CATALOG, Optional.of(metastore)));
-
-            queryRunner.installCoordinatorPlugin(new TvfPlugin());
-            queryRunner.loadTVFProvider("system");
+//
+//            queryRunner.installCoordinatorPlugin(new TvfPlugin());
+//            queryRunner.loadTVFProvider("system");
 
             if (addJmxPlugin) {
                 queryRunner.installPlugin(new JmxPlugin());

presto-native-execution/pom.xml

@@ -300,6 +300,11 @@
             <artifactId>presto-jdbc</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>com.facebook.presto</groupId>
+            <artifactId>presto-native-tvf</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>

presto-native-execution/presto_cpp/main/tvf/functions/Sequence.cpp

@@ -196,14 +196,14 @@ class Sequence : public TableFunctionSplitProcessor {
 
   static std::vector<TableSplitHandlePtr> getSplits(
       const TableFunctionHandlePtr& handle) {
-    static const int64_t kMaxSteps = 10;
+    static const int64_t kMaxSteps = 1000000;
     auto sequenceHandle =
         std::dynamic_pointer_cast<const SequenceHandle>(handle);
     auto start = sequenceHandle->start();
     auto stop = sequenceHandle->stop();
     auto step = sequenceHandle->step();
 
-    auto numSteps = (stop - start) / step;
+    auto numSteps = (stop - start) / step + 1;
 
     std::vector<TableSplitHandlePtr> splits = {};
     splits.reserve((numSteps/kMaxSteps) + 1);

presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeTvfFunctions.java

@@ -0,0 +1,54 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.facebook.presto.nativeworker;
+
+import com.facebook.presto.testing.QueryRunner;
+import com.facebook.presto.tests.AbstractTestQueryFramework;
+import com.facebook.presto.tvf.TvfPlugin;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.createRegion;
+
+@Test
+public abstract class AbstractTestNativeTvfFunctions
+        extends AbstractTestQueryFramework
+{
+    @BeforeClass
+    @Override
+    public void init() throws Exception
+    {
+        super.init();
+        getQueryRunner().installCoordinatorPlugin(new TvfPlugin());
+        getQueryRunner().loadTVFProvider("system");
+    }
+
+    @Override
+    protected void createTables()
+    {
+        createRegion((QueryRunner) getExpectedQueryRunner());
+    }
+
+    @Test
+    public void testSequence()
+    {
+        assertQuery("SELECT * FROM TABLE(sequence( start => 20, stop => 100, step => 5))");
+    }
+
+    @Test
+    public void testExcludeColumns()
+    {
+        assertQuery("SELECT * FROM TABLE(exclude_columns(input => TABLE(region), columns => DESCRIPTOR(regionkey, comment)))");
+    }
+}

presto-native-execution/src/test/java/com/facebook/presto/nativeworker/TestPrestoNativeTvfFunctions.java

@@ -0,0 +1,37 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.facebook.presto.nativeworker;
+
+import com.facebook.presto.testing.ExpectedQueryRunner;
+import com.facebook.presto.testing.QueryRunner;
+
+public class TestPrestoNativeTvfFunctions
+        extends AbstractTestNativeTvfFunctions
+{
+    @Override
+    protected QueryRunner createQueryRunner() throws Exception
+    {
+        return PrestoNativeQueryRunnerUtils.nativeHiveQueryRunnerBuilder()
+                .setAddStorageFormatToPath(true)
+                .build();
+    }
+
+    @Override
+    protected ExpectedQueryRunner createExpectedQueryRunner() throws Exception
+    {
+        return PrestoNativeQueryRunnerUtils.javaHiveQueryRunnerBuilder()
+                .setAddStorageFormatToPath(true)
+                .build();
+    }
+}