C++20

Author: xin-zhang2

presto-native-execution/CMakeLists.txt

@@ -24,7 +24,7 @@ execute_process(
   OUTPUT_VARIABLE SCRIPT_CXX_FLAGS
   RESULT_VARIABLE COMMAND_STATUS)
 
-set(CMAKE_CXX_STANDARD 17)
+set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED True)
 message("Appending CMAKE_CXX_FLAGS with ${SCRIPT_CXX_FLAGS}")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${SCRIPT_CXX_FLAGS}")

presto-native-execution/presto_cpp/main/http/HttpClient.cpp

@@ -542,7 +542,7 @@ folly::SemiFuture<std::unique_ptr<HttpResponse>> HttpClient::sendRequest(
   if (eventBase_ != nullptr) {
     if (delayMs > 0) {
       // schedule() is expected to be run in the event base thread
-      eventBase_->runInEventBaseThread([=]() {
+      eventBase_->runInEventBaseThread([=, this]() {
         eventBase_->schedule(sendCb, std::chrono::milliseconds(delayMs));
       });
     } else {

presto-native-execution/presto_cpp/main/types/tests/FunctionMetadataTest.cpp

@@ -48,12 +48,15 @@ class FunctionMetadataTest : public ::testing::Test {
     EXPECT_EQ(metadataList.size(), expectedSize);
     std::string expectedStr = slurp(test::utils::getDataPath(expectedFile));
     auto expected = json::parse(expectedStr);
+    auto comparator = [](const json& a, const json& b) {
+      return (a["outputType"] < b["outputType"]);
+    };
 
     json::array_t expectedList = expected[name];
-    std::sort(expectedList.begin(), expectedList.end());
-    std::sort(metadataList.begin(), metadataList.end());
+    std::sort(expectedList.begin(), expectedList.end(), comparator);
+    std::sort(metadataList.begin(), metadataList.end(), comparator);
     for (auto i = 0; i < expectedSize; i++) {
-      EXPECT_EQ(expectedList[i], metadataList[i]);
+      EXPECT_EQ(expectedList[i], metadataList[i]) << "Position: " << i;
     }
   }