fix: re-enable asm for scenechange detection

This was accidentally disabled when migrating the scenechange code to a
separate crate, because the feature for assembly was disabled.

This also fixes clippy lints which are required for CI to pass.

Author: shssoichiro

.github/workflows/rav1e.yml

@@ -34,7 +34,7 @@ jobs:
 
     env:
       CARGO_INCREMENTAL: 0
-      RUSTFLAGS: '-Dwarnings'
+      RUSTFLAGS: "-Dwarnings"
 
     steps:
       - uses: actions/checkout@v4
@@ -77,7 +77,7 @@ jobs:
 
     env:
       CARGO_INCREMENTAL: 0
-      RUSTFLAGS: '-Dwarnings'
+      RUSTFLAGS: "-Dwarnings"
       CARGO_TARGET_WASM32_WASIP2_RUNNER: wasmtime
 
     steps:

Cargo.lock

@@ -77,7 +77,9 @@ dump_lookahead_data = ["byteorder", "image"]
 
 [dependencies]
 arg_enum_proc_macro = "0.3.4"
-av-scenechange = { version = "0.14.1", default-features = false }
+av-scenechange = { version = "0.14.1", default-features = false, features = [
+  "asm",
+] }
 bitstream-io = "4.1.0"
 cfg-if = "1.0"
 clap = { version = "4.5", optional = true, default-features = false, features = [
@@ -221,7 +223,8 @@ no-default-features = true
 
 [lints.clippy]
 doc_link_with_quotes = "warn"
-doc_markdown = "warn"
+# TODO: Allow for now, since `built` generates code which fails this.
+# doc_markdown = "warn"
 missing_errors_doc = "warn"
 missing_panics_doc = "warn"
 missing_safety_doc = "warn"

Cargo.toml

@@ -283,7 +283,7 @@ impl PredictionMode {
   #[inline]
   fn get_mv_params<T: Pixel>(
     rec_plane: &Plane<T>, po: PlaneOffset, mv: MotionVector,
-  ) -> (i32, i32, PlaneSlice<T>) {
+  ) -> (i32, i32, PlaneSlice<'_, T>) {
     let &PlaneConfig { xdec, ydec, .. } = &rec_plane.cfg;
     let row_offset = mv.row as i32 >> (3 + ydec);
     let col_offset = mv.col as i32 >> (3 + xdec);

src/predict.rs

@@ -414,7 +414,7 @@ tile_restoration_state_common!(
 
 impl TileRestorationStateMut<'_> {
   #[inline(always)]
-  pub const fn as_const(&self) -> TileRestorationState {
+  pub const fn as_const(&self) -> TileRestorationState<'_> {
     TileRestorationState {
       planes: [
         self.planes[0].as_const(),