Skip to content

Commit d47d97f

Browse files
committed
Fixes #60: Diagnostic messages do not include banner/time
1 parent 50486ec commit d47d97f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

xunit.runner.visualstudio.testadapter/Visitors/DiagnosticMessageVisitor.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using System.Diagnostics;
23
using Microsoft.VisualStudio.TestPlatform.ObjectModel.Logging;
34
using Xunit.Abstractions;
45

@@ -9,18 +10,20 @@ public class DiagnosticMessageVisitor : TestMessageVisitor
910
readonly string assemblyDisplayName;
1011
readonly IMessageLogger logger;
1112
readonly bool showDiagnostics;
13+
readonly Stopwatch stopwatch;
1214

13-
public DiagnosticMessageVisitor(IMessageLogger logger, string assemblyDisplayName, bool showDiagnostics)
15+
public DiagnosticMessageVisitor(IMessageLogger logger, string assemblyDisplayName, bool showDiagnostics, Stopwatch stopwatch)
1416
{
1517
this.logger = logger;
1618
this.assemblyDisplayName = assemblyDisplayName;
1719
this.showDiagnostics = showDiagnostics;
20+
this.stopwatch = stopwatch;
1821
}
1922

2023
protected override bool Visit(IDiagnosticMessage diagnosticMessage)
2124
{
2225
if (showDiagnostics)
23-
logger.SendMessage(TestMessageLevel.Warning, String.Format("{0}: {1}", assemblyDisplayName, diagnosticMessage.Message));
26+
logger.SendMessage(TestMessageLevel.Warning, String.Format("[xUnit.net {0}] {1}: {2}", stopwatch.Elapsed, assemblyDisplayName, diagnosticMessage.Message));
2427

2528
return base.Visit(diagnosticMessage);
2629
}

xunit.runner.visualstudio.testadapter/VsTestRunner.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ void DiscoverTests<TVisitor>(IEnumerable<string> sources,
9898
}
9999
else
100100
{
101-
var diagnosticMessageVisitor = new DiagnosticMessageVisitor(logger, fileName, configuration.DiagnosticMessagesOrDefault);
101+
var diagnosticMessageVisitor = new DiagnosticMessageVisitor(logger, fileName, configuration.DiagnosticMessagesOrDefault, stopwatch);
102102

103103
using (var framework = new XunitFrontController(assemblyFileName, configFileName: null, shadowCopy: true, diagnosticMessageSink: diagnosticMessageVisitor))
104104
{
@@ -313,7 +313,7 @@ void RunTestsInAssembly(IFrameworkHandle frameworkHandle,
313313
assemblyFileName = Path.Combine(Windows.ApplicationModel.Package.Current.InstalledLocation.Path, Path.GetFileName(assemblyFileName));
314314
#endif
315315

316-
var diagnosticMessageVisitor = new DiagnosticMessageVisitor(frameworkHandle, assemblyDisplayName, runInfo.Configuration.DiagnosticMessagesOrDefault);
316+
var diagnosticMessageVisitor = new DiagnosticMessageVisitor(frameworkHandle, assemblyDisplayName, runInfo.Configuration.DiagnosticMessagesOrDefault, stopwatch);
317317
var controller = new XunitFrontController(assemblyFileName, configFileName: null, shadowCopy: true, diagnosticMessageSink: diagnosticMessageVisitor);
318318

319319
lock (toDispose)

0 commit comments

Comments
 (0)