Skip to content

Commit 7b28581

Browse files
Fix bugs
1 parent 61c41df commit 7b28581

File tree

7 files changed

+7
-13
lines changed

7 files changed

+7
-13
lines changed

src/components/PaginatedTable/TableChunk.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export const TableChunk = typedMemo(function TableChunk<T, F>({
7171
const columnsIds = React.useMemo(
7272
() =>
7373
//sort ids to prevent refetch if only order was changed
74-
useColumnsIdsInRequest ? columns.map((column) => column.name).toSorted() : undefined,
74+
useColumnsIdsInRequest ? columns.map((column) => column.name).toSorted() : [],
7575
[columns, useColumnsIdsInRequest],
7676
);
7777

src/components/PaginatedTable/requestBatcher.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ interface PaginatedTableParams<T, F> {
66
filters: F;
77
limit: number;
88
sortParams?: SortParams;
9-
columnsIds?: string[];
9+
columnsIds: string[];
1010
tableName: string;
1111
}
1212

src/components/PaginatedTable/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ type FetchDataParams<F, E = {}> = {
4848
offset: number;
4949
filters?: F;
5050
sortParams?: SortParams;
51-
columnsIds?: string[];
51+
columnsIds: string[];
5252
signal?: AbortSignal;
5353
} & E;
5454

src/containers/Nodes/getNodes.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ export const getNodes: FetchData<
3636
const sortField = getNodesColumnSortField(columnId);
3737
const sort = sortField ? prepareSortValue(sortField, sortOrder) : undefined;
3838

39-
const dataFieldsRequired = getRequiredDataFields(
40-
columnsIds ?? Object.keys(NODES_COLUMNS_TO_DATA_FIELDS),
41-
NODES_COLUMNS_TO_DATA_FIELDS,
42-
);
39+
const dataFieldsRequired = getRequiredDataFields(columnsIds, NODES_COLUMNS_TO_DATA_FIELDS,);
4340

4441
const schemePathParam =
4542
!isNil(path) && !isNil(databaseFullPath) ? {path, databaseFullPath} : undefined;

src/containers/Storage/PaginatedStorageGroupsTable/getGroups.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export function useGroupsGetter(shouldUseGroupsHandler: boolean) {
3333
const sort = sortField ? prepareSortValue(sortField, sortOrder) : undefined;
3434

3535
const dataFieldsRequired = getRequiredDataFields(
36-
columnsIds ?? Object.keys(GROUPS_COLUMNS_TO_DATA_FIELDS),
36+
columnsIds,
3737
GROUPS_COLUMNS_TO_DATA_FIELDS,
3838
);
3939

src/containers/Storage/PaginatedStorageNodesTable/getNodes.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ export const getStorageNodes: FetchData<
4242
const sortField = getNodesColumnSortField(columnId);
4343
const sort = sortField ? prepareSortValue(sortField, sortOrder) : undefined;
4444

45-
const dataFieldsRequired = getRequiredDataFields(
46-
columnsIds ?? Object.keys(NODES_COLUMNS_TO_DATA_FIELDS),
47-
NODES_COLUMNS_TO_DATA_FIELDS,
48-
);
45+
const dataFieldsRequired = getRequiredDataFields(columnsIds, NODES_COLUMNS_TO_DATA_FIELDS);
4946

5047
const response = await window.api.viewer.getNodes({
5148
type,

src/store/reducers/tableData.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ interface PaginatedTableParams<T, F> {
1111
filters: F;
1212
limit: number;
1313
sortParams?: SortParams;
14-
columnsIds?: string[];
14+
columnsIds: string[];
1515
tableName: string;
1616
noBatching?: boolean;
1717
}

0 commit comments

Comments
 (0)