fix: bot review

Author: artemmufazalov

src/services/api/metaSettings.ts

@@ -68,8 +68,9 @@ export class MetaSettingsAPI extends BaseMetaAPI {
 
         const batch = this.requestQueue;
         const user = this.currentUser;
-        this.requestQueue = undefined;
         clearTimeout(this.batchTimeout);
+        this.requestQueue = undefined;
+        this.batchTimeout = undefined;
 
         const settingNames = Array.from(batch.keys());
 

src/store/reducers/settings/useSetting.ts

@@ -39,9 +39,9 @@ export function useSetting<T>(
     const settingValue = useTypedSelector((state) => getSettingValue(state, name)) as T | undefined;
 
     const authUserSID = useTypedSelector(selectUser);
-    const anonymosUserId = useTypedSelector(selectID);
+    const anonymousUserId = useTypedSelector(selectID);
 
-    const user = authUserSID || anonymosUserId;
+    const user = authUserSID || anonymousUserId;
     const shouldUseMetaSettings = uiFactory.useMetaSettings && user && name;
 
     const shouldUseOnlyExternalSettings = shouldUseMetaSettings && preventSyncWithLS;
@@ -79,7 +79,7 @@ export function useSetting<T>(
             const parsedValue = parseSettingValue<T>(metaSetting.value);
             dispatch(setSettingValue(name, parsedValue));
         }
-    }, [shouldUseOnlyExternalSettings, metaSetting, name, dispatch]);
+    }, [shouldUseMetaSettings, shouldUseOnlyExternalSettings, metaSetting, name, dispatch]);
 
     // Load local value to backend
     React.useEffect(() => {
@@ -136,7 +136,7 @@ export function useSetting<T>(
                 setSettingValueToLS(name, value);
             }
         },
-        [shouldUseOnlyExternalSettings, user, name, debouncedSetMetaSetting],
+        [shouldUseMetaSettings, shouldUseOnlyExternalSettings, user, name, debouncedSetMetaSetting],
     );
 
     return {value: settingValue, saveValue, isLoading} as const;

src/store/reducers/settings/utils.ts

@@ -39,5 +39,5 @@ export function deleteValueFromLS(name: string | undefined) {
         return;
     }
 
-    delete localStorage[name];
+    localStorage.removeItem(name);
 }

src/utils/hooks/useTableResize.ts

@@ -26,9 +26,10 @@ export const useTableResize = (
     const handleSetupChange: HandleResize = React.useCallback(
         (columnId, columnWidth) => {
             setActualSizes((previousSetup) => {
-                const setup = Object.assign(Object.assign({}, previousSetup), {
+                const setup = {
+                    ...previousSetup,
                     [columnId]: columnWidth,
-                });
+                };
                 saveSizes(setup);
                 return setup;
             });