fix: fix custom item display on 1.21.4, fix text component potential crash

Author: zardoy

src/chatUtils.test.ts

@@ -11,24 +11,6 @@ const mapIncludeDefined = (props) => {
   }
 }
 
-/*
-TODO (nbt)
-{
-    "extra": [
-        {
-            "italic": 0,
-            "underlined": 0,
-            "bold": 0,
-            "color": "aqua",
-            "obfuscated": 0,
-            "strikethrough": 0,
-            "text": "minecraft:lift"
-        }
-    ],
-    "text": ""
-}
-*/
-
 test('formatMessage', () => {
   const result = formatMessage({
     'json': {

src/mineflayer/items.ts

@@ -38,7 +38,7 @@ export const getItemMetadata = (item: GeneralInputItem) => {
 
     const customTextComponent = componentMap.get('custom_name') || componentMap.get('item_name')
     if (customTextComponent) {
-      customText = customTextComponent.data.value
+      customText = nbt.simplify(customTextComponent.data)
     }
     const customModelComponent = componentMap.get('item_model')
     if (customModelComponent) {
@@ -70,6 +70,9 @@ export const getItemNameRaw = (item: Pick<import('prismarine-item').Item, 'nbt'>
   const { customText } = getItemMetadata(item as any)
   if (!customText) return
   try {
+    if (typeof customText === 'object') {
+      return customText
+    }
     const parsed = customText.startsWith('{') && customText.endsWith('}') ? mojangson.simplify(mojangson.parse(customText)) : fromFormattedString(customText)
     if (parsed.extra) {
       return parsed as Record<string, any>
@@ -78,7 +81,7 @@ export const getItemNameRaw = (item: Pick<import('prismarine-item').Item, 'nbt'>
     }
   } catch (err) {
     return {
-      text: customText
+      text: JSON.stringify(customText)
     }
   }
 }

src/react/MessageFormattedString.tsx

@@ -12,16 +12,6 @@ export default ({ message, fallbackColor, className }: {
 }) => {
   const messageJson = useMemo(() => {
     if (!message) return null
-    // const transformIfNbt = (x) => {
-    //   if (typeof x === 'object' && x?.type) return nbt.simplify(x) as Record<string, any>
-    //   // if (Array.isArray(x)) return x.map(transformIfNbt)
-    //   // if (typeof x === 'object') return Object.fromEntries(Object.entries(x).map(([k, v]) => [k, transformIfNbt(v)]))
-    //   return x
-    // }
-    // if (typeof message === 'object' && message.text?.text?.type) {
-    //   message.text.text = transformIfNbt(message.text.text)
-    //   message.text.extra = transformIfNbt(message.text.extra)
-    // }
     try {
       const texts = formatMessage(typeof message === 'string' ? fromFormattedString(message) : message)
       return texts.map(text => {