refactor: simplify path quoting to always add quotes

- Rename escape_path_if_needed to quote_path
- Remove space-checking logic, always quote paths
- Update tests to reflect simplified behavior

Author: UrielCuriel

src/debugger.rs

@@ -156,9 +156,7 @@ impl Debugger {
             DownloadedFileType::Uncompressed,
         )
         .map_err(|err| {
-            format!(
-                "Failed to download java-debug fork from {JAVA_DEBUG_PLUGIN_FORK_URL}: {err}"
-            )
+            format!("Failed to download java-debug fork from {JAVA_DEBUG_PLUGIN_FORK_URL}: {err}")
         })?;
 
         self.plugin_path = Some(jar_path.clone());
@@ -196,9 +194,7 @@ impl Debugger {
                 return Err(err.to_owned());
             }
 
-            println!(
-                "Could not fetch debugger: {err}\nFalling back to local version."
-            );
+            println!("Could not fetch debugger: {err}\nFalling back to local version.");
 
             let exists = fs::read_dir(prefix)
                 .ok()

src/util.rs

@@ -264,7 +264,7 @@ pub fn path_to_string<P: AsRef<Path>>(path: P) -> zed::Result<String> {
         .to_path_buf()
         .into_os_string()
         .into_string()
-        .map(escape_path_if_needed)
+        .map(quote_path)
         .map_err(|_| PATH_TO_STR_ERROR.to_string())
 }
 
@@ -347,29 +347,26 @@ pub fn should_use_local_or_download(
     }
 }
 
-// Escape path if included spaces
-// Add quotes to path if needed for avoid errors with spaces in path
-//
-// # Arguments
-// * `path` - The path to escape
-//
-// # Returns
-// * `String` - The escaped path
-//
-fn escape_path_if_needed(path: String) -> String {
-    if path.contains(' ') {
-        format!("\"{}\"", path)
-    } else {
-        path
-    }
+/// Quotes a path string to handle spaces safely
+///
+/// Wraps the path in double quotes to prevent errors when the path
+/// contains spaces or special characters.
+///
+/// # Arguments
+/// * `path` - The path to quote
+///
+/// # Returns
+/// A `String` containing the quoted path
+fn quote_path(path: String) -> String {
+    format!("\"{}\"", path)
 }
 
 #[cfg(test)]
 mod tests {
     use super::*;
 
     #[test]
-    fn test_path_to_string_with_spaces_windows() {
+    fn test_path_to_quoted_string_windows() {
         let path = PathBuf::from("C:\\Users\\User Name\\Projects\\zed-extension-java");
         let escaped = path_to_string(&path).unwrap();
         assert_eq!(
@@ -379,23 +376,9 @@ mod tests {
     }
 
     #[test]
-    fn test_path_to_string_without_spaces_windows() {
-        let path = PathBuf::from("C:\\Users\\UserName\\Projects\\zed-extension-java");
-        let escaped = path_to_string(&path).unwrap();
-        assert_eq!(escaped, "C:\\Users\\UserName\\Projects\\zed-extension-java");
-    }
-
-    #[test]
-    fn test_path_to_string_with_spaces_unix() {
+    fn test_path_to_quoted_string_unix() {
         let path = PathBuf::from("/home/username/Projects/zed extension java");
         let escaped = path_to_string(&path).unwrap();
         assert_eq!(escaped, "\"/home/username/Projects/zed extension java\"");
     }
-
-    #[test]
-    fn test_path_to_string_without_spaces_unix() {
-        let path = PathBuf::from("/home/username/Projects/zed-extension-java");
-        let escaped = path_to_string(&path).unwrap();
-        assert_eq!(escaped, "/home/username/Projects/zed-extension-java");
-    }
 }