Skip to content

Commit 7c57c88

Browse files
committed
Drop PHP 5.3 and broken tests from the test suite
1 parent eb001b8 commit 7c57c88

File tree

2 files changed

+0
-117
lines changed

2 files changed

+0
-117
lines changed

.github/workflows/shared_meterpreter_acceptance.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ jobs:
8282
- { name: java, runtime_version: 21 }
8383

8484
# PHP
85-
- { name: php, runtime_version: 5.3 }
8685
- { name: php, runtime_version: 7.4 }
8786
- { name: php, runtime_version: 8.3 }
8887
include:

spec/support/acceptance/session/php.rb

Lines changed: 0 additions & 116 deletions
Original file line numberDiff line numberDiff line change
@@ -18,48 +18,6 @@ module Acceptance::Session
1818
}
1919
],
2020
module_tests: [
21-
{
22-
name: "post/test/services",
23-
platforms: [
24-
[
25-
:linux,
26-
{
27-
skip: true,
28-
reason: "Windows only test"
29-
}
30-
],
31-
[
32-
:osx,
33-
{
34-
skip: true,
35-
reason: "Windows only test"
36-
}
37-
],
38-
[
39-
:windows,
40-
{
41-
skip: [
42-
:meterpreter_runtime_version,
43-
:==,
44-
"php5.3"
45-
],
46-
reason: "Skip PHP 5.3 as the tests timeout - due to cmd_exec taking 15 seconds for each call. Caused by failure to detect feof correctly - https://github.com/rapid7/metasploit-payloads/blame/c7f7bc2fc0b86e17c3bc078149c71745c5e478b3/php/meterpreter/meterpreter.php#L1127-L1145"
47-
}
48-
]
49-
],
50-
skipped: false,
51-
lines: {
52-
linux: {
53-
known_failures: []
54-
},
55-
osx: {
56-
known_failures: []
57-
},
58-
windows: {
59-
known_failures: []
60-
}
61-
}
62-
},
6321
{
6422
name: "post/test/cmd_exec",
6523
platforms: [:linux, :osx, :windows],
@@ -151,80 +109,6 @@ module Acceptance::Session
151109
}
152110
}
153111
},
154-
{
155-
name: "post/test/railgun",
156-
platforms: [:linux, :osx, :windows],
157-
skipped: false,
158-
lines: {
159-
linux: {
160-
known_failures: []
161-
},
162-
osx: {
163-
known_failures: []
164-
},
165-
windows: {
166-
known_failures: []
167-
}
168-
}
169-
},
170-
{
171-
name: "post/test/railgun_reverse_lookups",
172-
platforms: [:linux, :osx, :windows],
173-
skipped: false,
174-
lines: {
175-
linux: {
176-
known_failures: []
177-
},
178-
osx: {
179-
known_failures: []
180-
},
181-
windows: {
182-
known_failures: []
183-
}
184-
}
185-
},
186-
{
187-
name: "post/test/registry",
188-
platforms: [
189-
[
190-
:linux,
191-
{
192-
skip: true,
193-
reason: "Windows only test"
194-
}
195-
],
196-
[
197-
:osx,
198-
{
199-
skip: true,
200-
reason: "Windows only test"
201-
}
202-
],
203-
[
204-
:windows,
205-
{
206-
skip: [
207-
:meterpreter_runtime_version,
208-
:==,
209-
"php5.3"
210-
],
211-
reason: "Skip PHP 5.3 as the tests timeout - due to cmd_exec taking 15 seconds for each call. Caused by failure to detect feof correctly - https://github.com/rapid7/metasploit-payloads/blame/c7f7bc2fc0b86e17c3bc078149c71745c5e478b3/php/meterpreter/meterpreter.php#L1127-L1145"
212-
}
213-
]
214-
],
215-
skipped: false,
216-
lines: {
217-
linux: {
218-
known_failures: []
219-
},
220-
osx: {
221-
known_failures: []
222-
},
223-
windows: {
224-
known_failures: []
225-
}
226-
}
227-
},
228112
{
229113
name: "post/test/search",
230114
platforms: [:linux, :osx, :windows],

0 commit comments

Comments
 (0)