-
Notifications
You must be signed in to change notification settings - Fork 37
Update SDK versions #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update SDK versions #1502
Conversation
|
Merging to
|
|
@codex review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates SDK versions across multiple packages and configurations, including dependency bumps and Android build system modernization. This comprehensive update ensures compatibility with newer React Native ecosystem versions and build tools.
- Upgrades core dependencies like react-native-gesture-handler from 1.x/2.x to 2.28.0 across multiple packages
- Updates native SDK versions for iOS (1.16.5 → 1.17.0) and Android (2.9.69 → 2.9.77)
- Modernizes Android build configuration with Gradle 8.x, Kotlin 2.0, and Java 17 support
Reviewed Changes
Copilot reviewed 16 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sample-apps/*/package.json | Updates react-native-gesture-handler to 2.28.0 |
| packages/react-native-room-kit/package.json | Bumps package version to 1.3.0 and updates multiple dependencies |
| packages/react-native-room-kit/example/* | Updates dependencies and modernizes Android build configuration |
| packages/react-native-hms/* | Updates package version to 1.12.0 and native SDK versions |
| .java-version | Updates Java version to 17.0.16 |
Files not reviewed (4)
- packages/react-native-hms/example/package-lock.json: Language not supported
- packages/react-native-hms/package-lock.json: Language not supported
- packages/react-native-room-kit/example/package-lock.json: Language not supported
- packages/react-native-room-kit/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/react-native-room-kit/example/android/gradle.properties
Outdated
Show resolved
Hide resolved
| "react-native-gesture-handler": "2.15.0", | ||
| "react-native-image-picker": "^7.1.2", | ||
| "react-native-linear-gradient": "^2.7.3", | ||
| "react-native-gesture-handler": "^2.20.2", |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent react-native-gesture-handler version (2.20.2) compared to other packages using 2.28.0. This could lead to version conflicts and inconsistent behavior across the project.
| "react-native-gesture-handler": "^2.20.2", | |
| "react-native-gesture-handler": "^2.28.0", |
|
@codex review the PR |
No description provided.