chore: bump YahnisElsts/plugin-update-checker to v5.7 - #227
Open
nhrrob wants to merge 1 commit into
Open
Conversation
Contributor
|
@darylldoyle Is this package even being used on this project? I think most projects are using the packagist distro in their composer.json to install it. Maybe we need to look at Monitor to see which sites are using a vanilla Wp plugin install method which would hook into this package. |
Contributor
|
@claytoncollie do you have the access to check that in Monitor? If we can be sure this isn't being used much, then I think it's fine. @jeffpaul my only other concern would be people using it outside of Fueled, that might be relying on the update mechanism. I wonder if you have more insight on that |
Member
|
@darylldoyle I'm not aware of a great way to determine who's using this outside of Fueled, but if they are we can signal the deprecation in the changelog over the course of 2-3 releases? |
Contributor
|
@jeffpaul that makes sense to me! |
Member
|
So maybe we continue with bumping the version here but add to the changelog that we're going to deprecate it in the next release? |
Contributor
|
@darylldoyle This is the only thing I found in Monitor. Does not state how the plugin is installed. I thought the list would be much longer. |
Member
|
@claytoncollie that's still a decent list, seems perhaps we should still bump/include in 10up Experience? |
Contributor
|
@jeffpaul Agreed. Let's get it merged and we can deal with this later. @darylldoyle manages this repo so when he gets back from PTO, he will merge and release. |
There was a problem hiding this comment.
Pull request overview
This PR bumps the bundled yahnis-elsts/plugin-update-checker library from v5.1 to v5.7 (including composer.json, composer.lock, and the committed vendor/yahnis-elsts/plugin-update-checker tree) to avoid version conflicts with other 10up plugins and keep update-checker behavior current.
Changes:
- Update root Composer requirements/lockfile to require
yahnis-elsts/plugin-update-checker: 5.7. - Replace the vendor library’s internal minor-version namespace tree from
Puc/v5p1/*toPuc/v5p7/*and update the v5 facade to point to v5p7. - Pull upstream library updates (auth/download handling refactors, WP-CLI trigger support, autoupdate-field safety handling, docs/translation updates).
Reviewed changes
Copilot reviewed 1 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Bumps required PUC version to 5.7. |
| composer.lock | Updates locked PUC package metadata to v5.7 and related Composer metadata. |
| vendor/yahnis-elsts/plugin-update-checker/composer.json | Updates PUC’s autoloaded entry file to load-v5p7.php. |
| vendor/yahnis-elsts/plugin-update-checker/load-v5p7.php | Loads the v5p7 implementation and registers it as version 5.7. |
| vendor/yahnis-elsts/plugin-update-checker/plugin-update-checker.php | Updates library version header and switches loader to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5/PucFactory.php | Updates v5 facade to extend v5p7 factory. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Autoloader.php | v5p7 autoloader namespace update. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/PucFactory.php | v5p7 factory updates (escaping/error message hardening). |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/UpdateChecker.php | v5p7 core update-check logic updates (WP-CLI trigger, autoupdate gating, API exclusions). |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/WpCliCheckTrigger.php | Adds WP-CLI command hook support to trigger update checks. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Scheduler.php | Updates scheduler behavior and adds hook cleanup during upgrades. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/StateStore.php | Updates state handling + added sanity checks. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/InstalledPackage.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Metadata.php | Adds dynamic-property storage via magic accessors. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Update.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Utils.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/UpgraderStatus.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/OAuthSignature.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Plugin/UpdateChecker.php | Plugin update checker updated for v5p7 (componentType). |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Plugin/Update.php | Adds/supports autoupdate field in plugin update payload. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Plugin/Ui.php | Namespace bump + safer redirect API usage. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Plugin/PluginInfo.php | Adds autoupdate property support in plugin info. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Plugin/Package.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Theme/UpdateChecker.php | Theme update checker updated for v5p7 (componentType). |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Theme/Update.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Theme/Package.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/Api.php | Refactors auth handling and download-request filtering hooks. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/BaseChecker.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/VcsCheckerMethods.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/PluginUpdateChecker.php | Adds version sanity check + namespace bump. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/ThemeUpdateChecker.php | Namespace bump + import updates. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/GitHubApi.php | Refactors auth/download header handling via shared API logic. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/GitLabApi.php | Refactors request options via shared API logic. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/BitBucketApi.php | Changes BitBucket auth approach + request options via shared API logic. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/ReleaseAssetSupport.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/ReleaseFilteringFeature.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/Vcs/Reference.php | Namespace bump to v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/DebugBar/Extension.php | Debug Bar integration namespace bump. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/DebugBar/Panel.php | Escaping/ID handling updates in Debug Bar panel rendering. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/DebugBar/PluginExtension.php | Debug Bar integration namespace bump. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/DebugBar/PluginPanel.php | Debug panel escaping + fallback button rendering updates. |
| vendor/yahnis-elsts/plugin-update-checker/Puc/v5p7/DebugBar/ThemePanel.php | Debug panel escaping update. |
| vendor/yahnis-elsts/plugin-update-checker/vendor/ParsedownModern.php | Adjusts method signatures for upstream ParsedownModern changes. |
| vendor/yahnis-elsts/plugin-update-checker/README.md | Updates docs for v5p7 namespaces + release asset filtering guidance. |
| vendor/yahnis-elsts/plugin-update-checker/license.txt | Updates license header year. |
| vendor/yahnis-elsts/plugin-update-checker/languages/plugin-update-checker.pot | Updates POT metadata and file references for v5p7. |
| vendor/yahnis-elsts/plugin-update-checker/languages/plugin-update-checker-zh_CN.po | Updates translation metadata and file references. |
| vendor/yahnis-elsts/plugin-update-checker/languages/plugin-update-checker-fa_IR.po | Updates translation metadata and content. |
| vendor/yahnis-elsts/plugin-update-checker/languages/plugin-update-checker-zh_TW.po | Adds zh_TW translation file. |
| vendor/yahnis-elsts/plugin-update-checker/languages/plugin-update-checker-sr_RS.po | Adds sr_RS translation file. |
| vendor/yahnis-elsts/plugin-update-checker/languages/plugin-update-checker-el.po | Adds el translation file. |
| vendor/yahnis-elsts/plugin-update-checker/phpcs.xml | Removes vendored PHPCS ruleset file. |
| vendor/yahnis-elsts/plugin-update-checker/examples/plugin.json | Removes example plugin JSON file. |
| vendor/yahnis-elsts/plugin-update-checker/examples/theme.json | Removes example theme JSON file. |
| vendor/yahnis-elsts/plugin-update-checker/.gitignore | Removes vendored gitignore file. |
| vendor/yahnis-elsts/plugin-update-checker/.gitattributes | Removes vendored gitattributes file. |
| vendor/yahnis-elsts/plugin-update-checker/.editorconfig | Removes vendored editorconfig file. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bumps the YahnisElsts/plugin-update-checker dependency from v5.1 to v5.7 via composer update yahnis-elsts/plugin-update-checker --with-all-dependencies. This updates composer.json, composer.lock, and the committed vendor/yahnis-elsts/plugin-update-checker files (the internal Puc/v5p1/* tree is replaced by Puc/v5p7/*).
No code changes were made except the composer.json: 10up-experience.php uses the version-agnostic facade namespace YahnisElsts\PluginUpdateChecker\v5\PucFactory, which in v5.7 simply extends the new v5p7\PucFactory internally.
Closes #226
How to test the Change
Changelog Entry
Credits
Props @nhrrob
Checklist: