Rebrand Experience plugin UI for Fueled 1.19.0 - #235
Conversation
| * @return array[] Configuration items. | ||
| */ | ||
| private function get_experience_configuration() { | ||
| $rest_setting = get_option( 'tenup_restrict_rest_api', API::instance()->option_default ); |
There was a problem hiding this comment.
The REST API option can also be set at the code-level but this only reads from the DB. We should consider extracting the logic in https://github.com/10up/10up-experience/blob/develop/includes/classes/API/API.php#L91-L95 into a reusable helper within the API class. Something like:
/**
* Whether REST API restriction is actually enforced.
*
* Returns false when either restriction filter has been unhooked at the code
* level, in which case the stored option no longer describes real behaviour.
*
* @since 1.19
* @return bool
*/
public function restrictions_are_enforced() {
return has_filter( 'rest_authentication_errors', [ $this, 'restrict_rest_api' ] )
&& has_filter( 'rest_endpoints', [ $this, 'restrict_user_endpoints' ] );
}This could then be added to the check.
I don't think this is critical, just wanted to call it out.
|
@jakemgold This looks very sharp :) I ran an automated review against the code and also pulled it down locally to verify. Below are some suggestions that we might want to consider.
|
|
@darylldoyle we'll likely want to consider this alongside #236 as both do some rebranding across the plugin and will want to ensure they work well together / don't conflict, else will need to pick on to continue with and the other to close out. |
|
May also want to consider doing the 10up > Fueled work as part of a 2.0.0 version to mark the change more formally? |
Summary
Why
The plugin still presented substantial 10up branding and an outdated agency introduction inside client WordPress installations. This update brings customer-visible surfaces in line with Fueled while explaining the plugin's purpose and behavior more clearly.
Compatibility
This deliberately preserves the existing plugin folder and main filename, PHP namespace, constants, settings and user-meta keys, hooks and filters, text domain, page slugs, updater configuration, SSO plumbing, and Support Monitor endpoint. No migration is expected.
Known follow-up
The Fueled Recommended tab is still populated from the WordPress.org favorites associated with the
10upaccount. #234 tracks intentional curation, ownership, and future handling of that list. This PR changes its customer-facing label and explanatory copy but does not change its source.Validation
pluginsites.localLocalWP environment.npm run buildnpm run lint-stylenpm run lint-jscomposer lintwith zero errors; seven pre-existing warnings remain in untouched files.git diff --checkReview status
This is intentionally a draft for initial visual, content, and implementation review. Please do not merge until the Fueled branding direction and release scope are coordinated.
Relates to #187.
Follow-up: #234.