Fix video and model viewer - #6
Open
nicolas-daures wants to merge 5 commits into
Open
Conversation
In particular, fixes snapshots of 3D models from model-viewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The snapshot of a video with poster that was never played was empty. Now, if the
currentTimeof the video is 0 and there is a poster, the snapshot is based on the poster.When a
slottag does not haveassignedNodes, the snapshot does not take child nodes into account. The model-viewer (https://modelviewer.dev/) which displays 3D models could therefore not be displayed in a snapshot. Now, if theslottag does not haveassignedNodes, the snapshot uses thechildNodes.Types of changes
Self Check before Merge