Fix: manage images with relative path in iframe - #8
Open
nicolas-daures wants to merge 32 commits into
Open
Conversation
In particular, fixes snapshots of 3D models from model-viewer.
Fix video and model viewer
fix: avoid to clone children with display none
fix: webcam not allowed and image is empty
Fix: Image tag without image src
revert: avoid creating an empty image if loading fail, use imagePlaceholder instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the images with relative path in iframe.
Description
Images with relative path in iframe are not displayed because they do not contain the iframe domain.
Types of changes
Self Check before Merge