-
-
Notifications
You must be signed in to change notification settings - Fork 226
feat: Shadcn Registry Package #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
@I-3B is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks! I was working on the docs part (listing of installable items and copy/paste vs CLI methods) while on the plane, I'll open a PR later today. |
|
hi @franky47 ! |
|
Yeah I'll open a PR to the shadcn registry, as we have the green light from the man himself, but once #1189 is live. I have opened #1189 as a draft too for the docs UI part, we could stack yours on top of that one to add parseAsTuple. At a first glance, I'm not super keen on widening the exported API for internal purposes, I'll have to take a closer look once I'm home. But in #1189 I have all the "sources" for the registry as part of where it is deployed (in the docs package), and that causes problems in terms of dependencies, so a separate package might make more sense. Like I wanted to add the equivalent of the next-typed-links snippet for React Router's href utility, but that would have implied adding the react-router dependency to the docs, along with tests harnesses etc.. Better do a separate package, have it build the registry JSON files and mark it as a dependency of the docs. We'll still need to copy the built output into the docs' |
agree, alternative is to add a |
…mplement parseAsTuple tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add debug file as I thought it's an internal package detail that shouldn't be put in users' files, tradeoff of course is that debug flag doesn't work with community parsers
franky47
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged #1189, feel free to rebase on top of that.
It might make sense to expose the safeParse function as initially suggested (which would also make the feat: prefix a legitimate minor bump for the nuqs package).
packages/registry/registry.json
Outdated
| "path": "parsers/parseAsTuple.ts", | ||
| "type": "registry:file", | ||
| "target": "~/components/parsers/parseAsTuple.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This would also need to install the safeParse utility as it's used in the parseAsTuple file.
Maybe it would make sense to export it from nuqs then, as it's useful for custom parsers anyway.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
closes #1022 #1036 #1118
Checklist
parseAsTupleregistry itemparseAsTupleparseAsTuple