Skip to content

[deft-security] Fix 4 vulnerabilities in src/cache.c #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
539hex wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[deft-security] Fix 4 vulnerabilities in src/cache.c #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/cache.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@ void add_to_cache(const char *key, const char *value)
{
pthread_mutex_lock(&cache_mutex);
if (memory_cache == NULL) init_cache();
hash_table_insert(memory_cache, key, value);
// Update last_accessed for the item
DataItem *item = hash_table_search(memory_cache, key);
if (item) item->last_accessed = (unsigned int)time(NULL);
if (hash_table_insert(memory_cache, key, value) == 0) {
// Update last_accessed for the item
DataItem *item = hash_table_search(memory_cache, key);
if (item) item->last_accessed = (time_t)time(NULL);
}
if (item) item->last_accessed = (time_t)time(NULL);
pthread_mutex_unlock(&cache_mutex);
}

Expand All @@ -64,17 +66,21 @@ DataItem *get_from_cache(const char *key)
return NULL;
}
DataItem* item = hash_table_search(memory_cache, key);
DataItem* result = NULL;
if (item) {
if (time(NULL) - item->last_accessed > CACHE_TTL) {
if ((time_t)(time(NULL) - item->last_accessed) > CACHE_TTL) {
remove_from_cache_internal(key);
pthread_mutex_unlock(&cache_mutex);
return NULL;
}
item->hit_count++;
item->last_accessed = (unsigned int)time(NULL);
item->last_accessed = (time_t)time(NULL);
// Return a deep copy or use reference counting
result = malloc(sizeof(DataItem));
if (result) memcpy(result, item, sizeof(DataItem));
}
pthread_mutex_unlock(&cache_mutex);
return item;
return result;
}

void remove_from_cache(const char *key)
Expand Down