Skip to content

feature: m1-mcp-server added#66

Open
aaronmontilla wants to merge 3 commits into5G-MAG:mainfrom
aaronmontilla:feature/m1-mcp-server
Open

feature: m1-mcp-server added#66
aaronmontilla wants to merge 3 commits into5G-MAG:mainfrom
aaronmontilla:feature/m1-mcp-server

Conversation

@aaronmontilla
Copy link
Copy Markdown

m1-mcp-server version 1.0 added

@ErikGaida
Copy link
Copy Markdown

The installation instructions currently use pip directly. I think, it would be better to use a virtual environment, since on modern Debian/Ubuntu systems pip install often fails.

cd M1-mcp
pip install -r requirements.txt
fatal: Zielpfad 'M1-mcp' existiert bereits und ist kein leeres Verzeichnis.
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

Comment thread m1-mcp-server/tools/provisioning.py Outdated
Comment thread m1-mcp-server/README.md Outdated
Comment thread m1-mcp-server/tools/metrics_reporting.py Outdated
Comment thread m1-mcp-server/tools/consumption_reporting.py
@dsilhavy
Copy link
Copy Markdown
Contributor

@aaronmontilla Did you check all the comments by @ErikGaida ? If so, can you please resolve the conversations so we know if and how the comments have been addressed. Thank you!

The AF responds with 202 Accepted when deleting sessions, but the code
only checked for 200 and 204, causing the session state not to clear.

Refs 5G-MAG#66
samplingPeriod is a required field per TS26.512 and is now a mandatory
parameter. README updated to use a virtual environment to comply with
PEP 668 restrictions on modern Debian/Ubuntu systems.

Closes 5G-MAG#66
@aaronmontilla
Copy link
Copy Markdown
Author

I have just made the commits to the repository. The issues reported by @ErikGaida should now be resolved.

Comment thread m1-mcp-server/README.md
## Installation

```bash
git clone -b feature/m1-mcp-server https://github.com/aaronmontilla/rt-common-shared.git
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please adjust the link here to point to our repo and the main branch

Comment thread m1-mcp-server/LICENSE
@@ -0,0 +1,21 @@
MIT License
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the 5G-MAG license here, I will confirm with @jordijoangimenez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants