feature: m1-mcp-server added#66
Open
aaronmontilla wants to merge 3 commits into5G-MAG:mainfrom
Open
Conversation
|
The installation instructions currently use pip directly. I think, it would be better to use a virtual environment, since on modern Debian/Ubuntu systems pip install often fails. |
ErikGaida
suggested changes
Mar 31, 2026
Contributor
|
@aaronmontilla Did you check all the comments by @ErikGaida ? If so, can you please resolve the conversations so we know if and how the comments have been addressed. Thank you! |
The AF responds with 202 Accepted when deleting sessions, but the code only checked for 200 and 204, causing the session state not to clear. Refs 5G-MAG#66
samplingPeriod is a required field per TS26.512 and is now a mandatory parameter. README updated to use a virtual environment to comply with PEP 668 restrictions on modern Debian/Ubuntu systems. Closes 5G-MAG#66
Author
|
I have just made the commits to the repository. The issues reported by @ErikGaida should now be resolved. |
dsilhavy
requested changes
May 5, 2026
| ## Installation | ||
|
|
||
| ```bash | ||
| git clone -b feature/m1-mcp-server https://github.com/aaronmontilla/rt-common-shared.git |
Contributor
There was a problem hiding this comment.
Can you please adjust the link here to point to our repo and the main branch
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
Contributor
There was a problem hiding this comment.
We should add the 5G-MAG license here, I will confirm with @jordijoangimenez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m1-mcp-server version 1.0 added