Add 3D part preview with perimeter-based visualization#15
Open
Sethhondl wants to merge 5 commits into
Open
Conversation
Contributor
|
This branch also has conflicts. Please resolve and re-test |
- Replace 90° rotation button with text input for any angle (0-359°) - Add "Min" button to automatically find rotation with smallest bounding box - Fix bounding box calculation to accurately fit rotated geometry - Keep origin fixed at bottom-left while part rotates around it 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Output perimeter points from postprocessor as JSON for frontend use - Parse PERIMETER_POINTS in Flask app and include in response - Use perimeter from postprocessor in 3D preview instead of rectangular bounds - This shows the actual part outline in the G-code preview for plates Also includes tube facing improvements: - Fix Y coordinate calculations for tube facing arc patterns - Improve comments documenting tool edge positions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Pass tube_width and tube_length from backend to frontend - Use actual tube dimensions for 3D preview instead of G-code bounds - Fix coordinate transformation to properly position tube at origin - G-code toolpath now renders correctly relative to tube geometry Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sethhondl
force-pushed
the
feature/3d-part-preview
branch
from
a303117 to
175522d
Compare
- Changed tube_facing_offset from 0.125" to 0.0625" (1/16") - Phase 1 face is at Y=+0.0625", so holes need +0.0625" offset Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
joshsirota
reviewed
Jan 10, 2026
joshsirota
left a comment
joshsirota
left a comment
Contributor
There was a problem hiding this comment.
I just don't understand this change yet. This is an awfully big change, let's talk through what this really does.
| print(f"📄 Actual output file: {actual_output_path}") | ||
| elif line.startswith('PERIMETER_POINTS:'): | ||
| try: | ||
| import json |
Contributor
There was a problem hiding this comment.
Don't use inline imports. Isn't json already imported?
| elif line.startswith('PERIMETER_POINTS:'): | ||
| try: | ||
| import json | ||
| perimeter_points = json.loads(line.split('PERIMETER_POINTS:', 1)[1].strip()) |
Contributor
There was a problem hiding this comment.
What are these perimeter points? Is this a huge array? Are we basically trying to move all of the logic from the backend to the frontend? This seems awfully redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
Note: Some unit tests fail on origin/main due to pre-existing issue (tests expect
bearing_holesattribute that doesn't exist).🤖 Generated with Claude Code