Refactor the script to use OOP via Selenium's API and port it over to support the selenese target of the Maven Selenium Plugin#11
Open
paulbors wants to merge 4 commits into73rhodes:masterfrom
Open
Conversation
Instead of overwriting (not overloading) Selenium’s reset() function, it’s better to use the proxy design pattern so that if the original function changes we won’t break Selenium IDE’s init code by still using an outdated cut-n-paste ver of the imll
…nese" * Refactored the script and adopted Selenium's OOP way of doing things * Ported the script to support the Maven Selenium Plugin's selenese target
paulbors
changed the title
…nese" * Fixed SideFlow.initialize() for command loop in the IDE not to fall through the RC for comments
…nese" * Fixed SideFlow.initialize() and how the testFrame changes on page re-load for Selenium RC in Selenium Maven Plugin * Fixed the while loop off by a row bug * Refactored some of the undefined checks to also check for isNaN()
Author
|
Okay, this PR should be ready now. I tested the while loops in both the IDE and Selenium Maven Plugin for the selenese target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of overwriting (not overloading) Selenium’s reset() function,
it’s better to use the proxy design pattern so that if the original
function changes we won’t break Selenium IDE’s init code by still using
an outdated cut-n-paste ver of the impl
Cleaned up some of the code by removing white spaces and adding semicolons to all of the functions