Skip to content

Conversation

@embediver
Copy link

@embediver embediver commented Nov 12, 2025

PR just for testing CI.

  • Setup minimal Rust workflow for linting, tests, build
  • Apply fixes for failing actions
  • Add a workflow for license / license header checking

@mynetz
Copy link

mynetz commented Nov 13, 2025

Example for the license stuff is here: 82a4ba2af1c038b52450e69f1540048776ab9af3

You can run/test the configuration locally (from the project root)

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes/license-eye header check

In case you see an error you can fix it. Be aware that this just adds the header on-top of the file. If there is already some copyright note - that doesn't match the rule - you will have 2 then.

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes/license-eye header fix

Copy link

@mynetz mynetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@embediver
Copy link
Author

Example for the license stuff is here: 82a4ba2af1c038b52450e69f1540048776ab9af3

Added the license check and fixed the headers accordingly.

The copyright has to be clarified here as well.
Since this is forked from Caliptra, they hold it I guess.

@embediver embediver requested a review from mynetz November 17, 2025 14:37
Copy link

@mynetz mynetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM

Validate manually:

  • cargo fmt ✅
  • clippy ✅
  • cargo build ✅
  • cargo test ✅
  • license-eye ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants