-
Notifications
You must be signed in to change notification settings - Fork 0
Minimal CI #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Minimal CI #2
Conversation
Signed-off-by: Marvin Gudel <[email protected]>
Signed-off-by: Marvin Gudel <[email protected]>
|
Example for the license stuff is here: 82a4ba2af1c038b52450e69f1540048776ab9af3 You can run/test the configuration locally (from the project root) In case you see an error you can fix it. Be aware that this just adds the header on-top of the file. If there is already some copyright note - that doesn't match the rule - you will have 2 then. |
mynetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, maybe copy from https://github.com/9elements/mctp-lib/tree/minimal_ci
:P
Signed-off-by: Marvin Gudel <[email protected]>
Signed-off-by: Marvin Gudel <[email protected]>
Signed-off-by: Marvin Gudel <[email protected]>
Signed-off-by: Marvin Gudel <[email protected]>
Added the license check and fixed the headers accordingly. The copyright has to be clarified here as well. |
mynetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! LGTM
Validate manually:
- cargo fmt ✅
- clippy ✅
- cargo build ✅
- cargo test ✅
- license-eye ✅
PR just for testing CI.