Code updates that improve the performance of benchmark_ALE case with density-mapped diags#63
Draft
manodeep wants to merge 7 commits into
Draft
Code updates that improve the performance of benchmark_ALE case with density-mapped diags#63manodeep wants to merge 7 commits into
manodeep wants to merge 7 commits into
Conversation
…es inlining and vectorization)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #47
The base case was benchmark_ALE with the following patch (patch generated with
git diff --patch MOM_input diag_table):The baseline
benchmark_ALEruntime improves from 145s (possibly longer since I had forgotten to compile with-fp-model=precisefor the baseline) to 98s for a version that contained all of these changes (and some more that made minor performance impact) - about a 30% improvement in runtime. Most of the improvement comes from inliningdensity_anomaly_elem_Roquet_rho(~22s) and the extrapolation check reordering inget_polynomial_coordinate(~12s). The changes for the EOS are currently confined to the Roquet but would (should?) be carried across to the other EOS'.From my tests with the deployments, the OM3 25k IAF runtime improves by about 10% (but that's probably because the load-balancing is now off)
I will add in performance tables here, once I have them in a easily-parseable format