Install build-atmos/bin for access3 UM variant#449
Open
blimlim wants to merge 2 commits into
Open
Conversation
anton-seaice
previously approved these changes
Jun 25, 2026
anton-seaice
left a comment
anton-seaice
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, you better check with @penguian
penguian
requested changes
Jun 25, 2026
| # List of executables to install, always install recon | ||
| um_exe = ["recon"] | ||
| # List of executables to install | ||
| um_exe = ["recon", "atmos"] |
Collaborator
There was a problem hiding this comment.
Move lines 72 and 73 to just before line 92. The intervening if statement does not refer to um_exe.
blimlim
force-pushed
the
448-access3-install-um-bin
branch
from
265eda4 to
ea4cdb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #448
This PR modifies the UM spack package to also install the
build-atmos/bindirectory for theaccess3variant. This ensures that theum-atmosandum_script_functionsscripts are installed, which are required for running ACCESS-CM3.