Use double precision for time bounds#101
Open
blimlim wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96.
Time bounds precision:
The time variable uses double precision while its bounds use single precision. When the time is large relative to the origin, inaccurate bounds can be written to the output files for hourly data. E.g. for ESM1.6:
This PR swaps the time bounds variables to use double precision. With the changes, we get:
Using the
release-1deg_jra55_iafbranch for OM2 there aren't any immediate differences in the bounds, as the time origin is much closer to the data:Without changes
With changes
Bounds on instantaneous data
For the netCDF io, the lower time bound for single timestep data is also off:
The
io_pio/ice_history_write.F90code already omits time bounds forhistfreq(ns) == 1. This PR copies this change over toio_netcdf/ice_history_write.F90.Unaddressed issues
There are still a couple of odd things with the hourly data: