Add defaults and checking for per_cell and per_tile#10
Open
Whyborn wants to merge 2 commits into
Open
Conversation
This change ensures that the per_cell and per_tile fields in MappingConf do not end up with `None` values if the config file has no listed items under per_cell or per_tile.
Contributor
Author
|
Alex's commit makes it behaves as expected if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restart adjustment script would fail if the user decided to remove either the
per_cellorper_tileentries in the config, which are valid choices to make. This adds handling for that case, and ensures that the values supplied for this entry are iterable as expected by the rest of the script.@NortonAlex is currently testing this.