Skip to content

Fix missing cell_methods for instantaneous files from um2nc#9

Merged
joshuatorrance merged 1 commit into
mainfrom
7-fix-cell-methods
Jun 30, 2026
Merged

Fix missing cell_methods for instantaneous files from um2nc#9
joshuatorrance merged 1 commit into
mainfrom
7-fix-cell-methods

Conversation

@joshuatorrance

Copy link
Copy Markdown
Collaborator
  • Added fix_cell_methods that will add time:point to the cell_methods of a variable if:
    • There is time
    • There are no time bounds (i.e. time has not bounds attribute)
    • The string time is not present in the current cell_methods
  • The number of arguments to process_file was getting silly so this function now uses kwargs

Closes #7

@joshuatorrance joshuatorrance requested a review from blimlim June 30, 2026 03:14
@joshuatorrance joshuatorrance marked this pull request as ready for review June 30, 2026 03:14

@blimlim blimlim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @joshuatorrance, this looks great!

@joshuatorrance joshuatorrance merged commit 7016fb2 into main Jun 30, 2026
4 checks passed
@joshuatorrance joshuatorrance deleted the 7-fix-cell-methods branch June 30, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Something (splitnc?) needs to handle instantaneous variables missing cell_methods = time: point

2 participants